| commit | 12150816f701c912a32a376754ab28dd3878833a | [log] [tgz] |
|---|---|---|
| author | Oleg Zaytsev <mail@olegzaytsev.com> | Mon Mar 10 09:25:54 2025 +0000 |
| committer | Gopher Robot <gobot@golang.org> | Thu Mar 13 05:30:06 2025 -0700 |
| tree | 5fbc88b07f8e59687fa3feb7fb6c4b6da13a69df | |
| parent | 312450e473eae9f9e6173ad895c80bc5ea2f79ad [diff] |
http2: improve error when server sends HTTP/1 If for some reason the server sends an HTTP/1.1 response starting with "HTTP/1.1 " (9 bytes), http2 transport interprets that as a valid frame header for an expected payload of ~4MB, and fails with non-descriptive messages like "unexpected EOF". This could happen, for example, if ALPN is misconfigured on the server's load balancer. This change attempts to improve that feedback by noting in the error messages whenever the frame header was exactly the "HTTP/1.1 " bytes. Change-Id: I7bf9ed2ee7f299b939b9004386f5bfa30a4e9032 GitHub-Last-Rev: d6e410daa3a1aa5d1c85ff99c929d27b81cf4783 GitHub-Pull-Request: golang/net#224 Reviewed-on: https://go-review.googlesource.com/c/net/+/623155 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Sean Liao <sean@liao.dev>
This repository holds supplementary Go networking packages.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://go.dev/doc/contribute.
The git repository is https://go.googlesource.com/net.
The main issue tracker for the net repository is located at https://go.dev/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.