)]}' { "commit": "249dc8530c0efc2766606a940c1c50b434b2f1cd", "tree": "4744e69f1d0953aedd9e3192f476982605fbf398", "parents": [ "aa35264064ba97668fab8736503e428bde0b656c" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Thu Nov 08 18:34:23 2018 -0500" }, "committer": { "name": "Nigel Tao", "email": "nigeltao@golang.org", "time": "Fri Nov 09 23:22:46 2018 +0000" }, "message": "draw: re-enable the image.Rectangle DstMask fast path\n\nThis change reverts the remaining part of CL 9463,\nthe image.Rectangle DstMask fast path, since Go 1.5\nhas been released.\n\n\t$ go test -bench\u003d. -count\u003d5 -timeout\u003d1h \u003e before.txt\n\t$ # apply change\n\t$ go test -bench\u003d. -count\u003d5 -timeout\u003d1h \u003e after.txt\n\t$ benchstat before.txt after.txt\n\tname old time/op new time/op delta\n\tSimpleScaleCopy-8 23.4µs ± 3% 21.8µs ± 4% -7.14% (p\u003d0.016 n\u003d5+5)\n\tSimpleTransformCopy-8 22.6µs ± 6% 21.4µs ± 1% -5.07% (p\u003d0.008 n\u003d5+5)\n\tSimpleTransformScale-8 904µs ± 0% 900µs ± 0% ~ (p\u003d0.056 n\u003d5+5)\n\tScaleNNLargeDown-8 641µs ± 1% 643µs ± 1% ~ (p\u003d0.548 n\u003d5+5)\n\tScaleABLargeDown-8 1.50ms ± 1% 1.50ms ± 1% ~ (p\u003d0.413 n\u003d5+4)\n\tScaleBLLargeDown-8 192ms ± 5% 196ms ± 4% ~ (p\u003d0.095 n\u003d5+5)\n\tScaleCRLargeDown-8 355ms ± 4% 350ms ± 2% ~ (p\u003d0.690 n\u003d5+5)\n\tScaleNNDown-8 134µs ± 2% 126µs ± 1% -5.68% (p\u003d0.008 n\u003d5+5)\n\tScaleABDown-8 261µs ± 3% 256µs ± 1% -1.92% (p\u003d0.016 n\u003d5+5)\n\tScaleBLDown-8 2.42ms ± 3% 2.44ms ± 8% ~ (p\u003d0.841 n\u003d5+5)\n\tScaleCRDown-8 4.36ms ± 1% 4.85ms ± 4% +11.22% (p\u003d0.008 n\u003d5+5)\n\tScaleNNUp-8 6.27ms ± 2% 6.72ms ± 3% +7.20% (p\u003d0.008 n\u003d5+5)\n\tScaleABUp-8 12.8ms ± 1% 13.8ms ± 2% +7.26% (p\u003d0.008 n\u003d5+5)\n\tScaleBLUp-8 17.5ms ± 7% 17.4ms ± 2% ~ (p\u003d1.000 n\u003d5+5)\n\tScaleCRUp-8 23.2ms ± 2% 23.1ms ± 4% ~ (p\u003d0.690 n\u003d5+5)\n\tScaleNNSrcRGBA-8 419µs ± 1% 421µs ± 3% ~ (p\u003d0.690 n\u003d5+5)\n\tScaleNNSrcUnif-8 3.35µs ± 3% 3.35µs ± 2% ~ (p\u003d1.000 n\u003d5+5)\n\tScaleNNOverRGBA-8 470µs ± 1% 479µs ± 5% ~ (p\u003d0.548 n\u003d5+5)\n\tScaleNNOverUnif-8 102µs ± 2% 102µs ± 1% ~ (p\u003d0.222 n\u003d5+5)\n\tTformNNSrcRGBA-8 215µs ± 1% 213µs ± 1% ~ (p\u003d0.222 n\u003d5+5)\n\tTformNNSrcUnif-8 84.2µs ± 1% 86.6µs ± 2% +2.82% (p\u003d0.016 n\u003d5+5)\n\tTformNNOverRGBA-8 351µs ± 5% 359µs ± 0% ~ (p\u003d0.151 n\u003d5+5)\n\tTformNNOverUnif-8 101µs ± 1% 104µs ± 1% +3.47% (p\u003d0.008 n\u003d5+5)\n\tScaleABSrcGray-8 399µs ± 2% 400µs ± 2% ~ (p\u003d0.690 n\u003d5+5)\n\tScaleABSrcNRGBA-8 795µs ± 1% 809µs ± 4% ~ (p\u003d0.095 n\u003d5+5)\n\tScaleABSrcRGBA-8 807µs ± 1% 807µs ± 2% ~ (p\u003d1.000 n\u003d5+5)\n\tScaleABSrcYCbCr-8 1.50ms ± 1% 1.48ms ± 0% -0.76% (p\u003d0.032 n\u003d5+5)\n\tScaleABOverGray-8 396µs ± 0% 395µs ± 1% ~ (p\u003d0.421 n\u003d5+5)\n\tScaleABOverNRGBA-8 886µs ± 1% 885µs ± 1% ~ (p\u003d0.556 n\u003d4+5)\n\tScaleABOverRGBA-8 893µs ± 1% 895µs ± 1% ~ (p\u003d0.310 n\u003d5+5)\n\tScaleABOverYCbCr-8 1.49ms ± 1% 1.49ms ± 1% ~ (p\u003d0.548 n\u003d5+5)\n\tTformABSrcGray-8 359µs ± 1% 364µs ± 3% ~ (p\u003d0.421 n\u003d5+5)\n\tTformABSrcNRGBA-8 618µs ± 1% 660µs ± 3% +6.81% (p\u003d0.008 n\u003d5+5)\n\tTformABSrcRGBA-8 614µs ± 1% 638µs ± 5% +3.94% (p\u003d0.008 n\u003d5+5)\n\tTformABSrcYCbCr-8 903µs ± 1% 913µs ± 2% ~ (p\u003d0.056 n\u003d5+5)\n\tTformABOverGray-8 362µs ± 3% 358µs ± 1% ~ (p\u003d0.421 n\u003d5+5)\n\tTformABOverNRGBA-8 691µs ± 1% 690µs ± 1% ~ (p\u003d0.841 n\u003d5+5)\n\tTformABOverRGBA-8 671µs ± 1% 673µs ± 1% ~ (p\u003d0.690 n\u003d5+5)\n\tTformABOverYCbCr-8 904µs ± 1% 906µs ± 0% ~ (p\u003d0.190 n\u003d5+4)\n\tScaleCRSrcGray-8 9.24ms ± 1% 9.16ms ± 1% ~ (p\u003d0.222 n\u003d5+5)\n\tScaleCRSrcNRGBA-8 21.9ms ± 2% 21.7ms ± 1% ~ (p\u003d0.222 n\u003d5+5)\n\tScaleCRSrcRGBA-8 22.5ms ± 8% 21.8ms ± 1% ~ (p\u003d1.000 n\u003d5+5)\n\tScaleCRSrcYCbCr-8 43.6ms ± 1% 43.9ms ± 1% ~ (p\u003d0.222 n\u003d5+5)\n\tScaleCROverGray-8 9.24ms ± 0% 9.35ms ± 6% ~ (p\u003d0.690 n\u003d5+5)\n\tScaleCROverNRGBA-8 21.9ms ± 1% 21.8ms ± 1% ~ (p\u003d0.548 n\u003d5+5)\n\tScaleCROverRGBA-8 21.8ms ± 0% 22.0ms ± 1% +0.94% (p\u003d0.008 n\u003d5+5)\n\tScaleCROverYCbCr-8 43.5ms ± 1% 44.1ms ± 1% +1.53% (p\u003d0.008 n\u003d5+5)\n\tTformCRSrcGray-8 3.16ms ± 4% 3.06ms ± 1% ~ (p\u003d0.056 n\u003d5+5)\n\tTformCRSrcNRGBA-8 4.21ms ± 1% 4.20ms ± 1% ~ (p\u003d0.841 n\u003d5+5)\n\tTformCRSrcRGBA-8 4.29ms ± 1% 4.29ms ± 1% ~ (p\u003d0.841 n\u003d5+5)\n\tTformCRSrcYCbCr-8 5.55ms ± 1% 5.58ms ± 0% +0.67% (p\u003d0.032 n\u003d5+4)\n\tTformCROverGray-8 3.08ms ± 1% 3.07ms ± 2% ~ (p\u003d0.421 n\u003d5+5)\n\tTformCROverNRGBA-8 4.40ms ± 1% 4.39ms ± 0% ~ (p\u003d0.841 n\u003d5+5)\n\tTformCROverRGBA-8 4.50ms ± 5% 4.44ms ± 0% ~ (p\u003d0.730 n\u003d5+4)\n\tTformCROverYCbCr-8 5.57ms ± 0% 5.61ms ± 1% ~ (p\u003d0.095 n\u003d5+5)\n\nChange-Id: I981861c28e103b68275a82e051d2999a8e714502\nReviewed-on: https://go-review.googlesource.com/c/148575\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "11784d49a0cc53a85b404c8b54117b7be81f2995", "old_mode": 33188, "old_path": "draw/scale.go", "new_id": "00121a129def3d80a55398856fbd44f0e4732e9c", "new_mode": 33188, "new_path": "draw/scale.go" } ] }