| commit | 08ca817286cef4a50486ff2dc212ec148ff956ae | [log] [tgz] |
|---|---|---|
| author | Nigel Tao <nigeltao@golang.org> | Wed Mar 08 22:14:31 2023 +1100 |
| committer | Nigel Tao <nigeltao@golang.org> | Tue Mar 21 11:35:05 2023 +0000 |
| tree | fc91c0c0b95ac72b0f1b3655925f96511f93105e | |
| parent | b6ac75bc5918c3a0a2200faa20aedebc76d5b349 [diff] |
font: have Glyph return !ok for U+FFFD substitute The other return values may still be non-zero, but this lets callers identify when substitution happens. "TODO: is falling back on the U+FFFD glyph the responsibility of the Drawer or the Face?" was resolved. The answer is "the Face". For kerning, the previous rune is unchanged (and not set to U+FFFD). This also fixes an inconsistency in the basicfont.Face implementation, where GlyphAdvance and GlyphBounds would unconditionally return a non-zero advance, but Glyph could return a zero advance when the Face doesn't have a U+FFFD entry. Fixes golang/go#58252 Change-Id: Ie97e68e1d5e2efd13c9e84ad12db4495d83a5ca3 Reviewed-on: https://go-review.googlesource.com/c/image/+/474376 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Nigel Tao (INACTIVE; USE @golang.org INSTEAD) <nigeltao@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Nigel Tao <nigeltao@golang.org>
This repository holds supplementary Go image libraries.
The easiest way to install is to run go get -u golang.org/x/image/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/image.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the image repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/image:” in the subject line, so it is easy to find.