tree 8608b837340ae532fc5c4364d6fb02ba0573cd71
parent 9d2ecf553a16eecc7047e20262918a672f8dc4b9
author Brad Fitzpatrick <bradfitz@golang.org> 1454354137 +0000
committer Brad Fitzpatrick <bradfitz@golang.org> 1454354137 +0000

Don't call t.FailNow in goroutines started by tests.

The docs at https://golang.org/pkg/testing/#T.FailNow say:

> FailNow must be called from the goroutine running the test or
> benchmark function, not from other goroutines created during the
> test.

(Fatalf is documented as "Fatalf is equivalent to Logf followed by
FailNow.")

This was manifesting itself as a race with two concurrently failing
goroutines in my other CL, masking whatever the real problem was.