|author||Brad Fitzpatrick <email@example.com>||Mon Feb 01 19:15:37 2016 +0000|
|committer||Brad Fitzpatrick <firstname.lastname@example.org>||Mon Feb 01 19:15:37 2016 +0000|
Don't call t.FailNow in goroutines started by tests. The docs at https://golang.org/pkg/testing/#T.FailNow say: > FailNow must be called from the goroutine running the test or > benchmark function, not from other goroutines created during the > test. (Fatalf is documented as "Fatalf is equivalent to Logf followed by FailNow.") This was manifesting itself as a race with two concurrently failing goroutines in my other CL, masking whatever the real problem was.
To install this package, you need to install Go 1.4 or above and setup your Go workspace on your computer. The simplest way to install the library is to run:
$ go get google.golang.org/grpc
This requires Go 1.4 or above.
The grpc package should only depend on standard Go packages and a small number of exceptions. If your contribution introduces new dependencies which are NOT in the list, you need a discussion with gRPC-Go authors and consultants.