tree 056c88c308fbe3118a84dd016c71b82a122680dd
parent 4d0f5a9df01deab877d1deeb95e83c2cfd9f51f7
author Than McIntosh <thanm@google.com> 1612819982 -0500
committer Than McIntosh <thanm@google.com> 1612827759 +0000

gollvm: rework code for updating call attributes

Revise the code that gollvm uses to update function call attributes.
LLVM trunk has recently changed in ways that make it essential to call
AttrBuilder::addByValAttr for a "by value" parameter as opposed to
calling addAttribute() on the call directly (without the use of
addByValAttr the proper type isn't being recorded/cached, causing
a verifier error).

Updates golang/go#43870.

Change-Id: Ic229cd05328c32cc2bf1d4cde338ad3944134255
Reviewed-on: https://go-review.googlesource.com/c/gollvm/+/290532
Trust: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>