tree fa9ff9e2e9dca2be0358fe1a209477f24f08610e
parent 6e7210829f1eab2356cc5ae1f14060a737b31052
author Than McIntosh <thanm@google.com> 1496849353 -0400
committer Than McIntosh <thanm@google.com> 1497016695 +0000

gollvm: cleanup of convert_expression()

Fix some bugs in Llvm_backend::convert_expression(), mostly related to
conversions between ints and floats. A lot of the int/int conversions
were being generated incorrectly due to the fact that the previous
implementation would do nothing if the underlying LLVM types matched
(ex: int32 -> uint32); this is now cleaned up. Fix a couple of cases
where the conversion code was calling llvm::Type::isFloatTy instead of
llvm::Type::isFloatingPointTy.  Improve the unit test coverage for
scalar int/float conversions.

Change-Id: I43f9b5b9766a23e8e2031af6182218d3fd57585a
Reviewed-on: https://go-review.googlesource.com/45139
Reviewed-by: Cherry Zhang <cherryyz@google.com>