tree b51393e9c17295ed434523c94fd701f061f1cd50
parent 5ccb2d8593963e06ec3a35d362b384e82301d9f0
author Cherry Zhang <cherryyz@google.com> 1548360895 -0500
committer Ian Lance Taylor <iant@golang.org> 1548722925 +0000

runtime: use the call instruction's PC for panic-in-runtime detection

If a panic happens in the runtime we turn that into a fatal error.
We use the caller's PC to determine if the panic call is inside
the runtime. getcallerpc returns the PC immediately after the
call instruction. If the call is the very last instruction of a
function, it may not find this PC belong to a runtime function,
giving false result. We need to back off the PC by 1 to the call
instruction.

The gc runtime doesn't do this because the gc compiler always
emit an instruction following a panic call, presumably an UNDEF
instruction which turns into an architecture-specific illegal
instruction. Our compiler doesn't do this.

Change-Id: Iac4b5e568c9636100a5a18f737eb2a256c1ca5ca
Reviewed-on: https://go-review.googlesource.com/c/159437
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>