commit 81d9f6d05c2bb92b2b3af02807713b6bed9bf053
author Than McIntosh <thanm@google.com> Wed Jun 07 09:58:25 2017 -0400
committer Ian Lance Taylor <iant@golang.org> Thu Jun 08 18:41:18 2017 +0000
tree c16da7cf1c4fcc837335b6dd9ad6f24b16962e3c
parent 4b857cde45939f0e9f3cf89b9e347b6f6ebe0f8f

compiler: lvalue context fixes in Unary_expression::do_get_backend

A couple of the Backend::var_expression invocations in
Unary_expression::do_get_backend were selecting "lvalue" context
incorrectly (these var exprs were not in an assignment or LHS
position); fix is to change back to "rvalue" context.

Change-Id: I429cc214febfd6955f12384c0c515385059fb69c
Reviewed-on: https://go-review.googlesource.com/45136
Reviewed-by: Ian Lance Taylor <iant@golang.org>

go/expressions.cc

diff --git a/go/expressions.cc b/go/expressions.cc
index eaf492f..5689c77 100644
--- a/go/expressions.cc
+++ b/go/expressions.cc
@@ -4370,7 +4370,7 @@
 	  gogo->backend()->implicit_variable_set_init(implicit, buf, btype,
 						      true, copy_to_heap, false,
 						      bexpr);
-	  bexpr = gogo->backend()->var_expression(implicit, VE_lvalue, loc);
+	  bexpr = gogo->backend()->var_expression(implicit, VE_rvalue, loc);
 
 	  // If we are not copying a slice initializer to the heap,
 	  // then it can be changed by the program, so if it can
@@ -4380,7 +4380,7 @@
 	      && this->expr_->type()->has_pointer())
 	    {
 	      Bexpression* root =
-                  gogo->backend()->var_expression(implicit, VE_lvalue, loc);
+                  gogo->backend()->var_expression(implicit, VE_rvalue, loc);
 	      root = gogo->backend()->address_expression(root, loc);
 	      Type* type = Type::make_pointer_type(this->expr_->type());
 	      gogo->add_gc_root(Expression::make_backend(root, type, loc));
@@ -4400,7 +4400,7 @@
                                                 true, false, btype, loc);
           gogo->backend()->immutable_struct_set_init(decl, buf, true, false,
                                                      btype, loc, bexpr);
-          bexpr = gogo->backend()->var_expression(decl, VE_lvalue, loc);
+          bexpr = gogo->backend()->var_expression(decl, VE_rvalue, loc);
         }
 
       go_assert(!this->create_temp_ || this->expr_->is_variable());