tree 2f8c0092c49a8e7333674a6e20bbc111b0ea445f
parent 7dea652169d3f5333db8a286248c66ba94e1efe0
author Than McIntosh <thanm@google.com> 1573750078 -0500
committer Ian Lance Taylor <iant@golang.org> 1573788494 +0000

compiler: fix buglet in function inlining related to sink names

When the compiler writes an inlinable function to the export data,
parameter names are written out (in Export::write_name) using the
Gogo::message_name as opposed to a raw/encoded name. This means that
sink parameters (those named "_") get created with the name "_"
instead of "._" (the name created by the lexer/parser). This confuses
Gogo::is_sink_name, which looks for the latter sequence and not just
"_". This can cause issues later on if an inlinable function is
imported and fed through the rest of the compiler (things that are
sinks are no recognized as such). To fix these issues, change
Gogo::is_sink_name to return true for either variants ("_" or "._").

Fixes golang/go#35586.

Change-Id: I5cddebca0d30932ac76ebd5ca8e765d849323b35
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/207259
Reviewed-by: Ian Lance Taylor <iant@golang.org>