tree 65397b43e439c2b5f0f78d7ca2a49bef0608d7f2
parent 489620d8787a988aea4a083803608b55703f78a6
author Brad Fitzpatrick <bradfitz@golang.org> 1498504044 +0000
committer Brad Fitzpatrick <bradfitz@golang.org> 1498505567 +0000

net/http/httputil: always deep copy the Request.Header map in ReverseProxy

We used to do it sometimes as an optimization, but the optimization is
flawed: in all non-contrived cases we need to deep clone the map
anyway. So do it always, which both simplifies the code but also fixes
the X-Forward-For value leaking to the caller's Request, as well as
modifications from the optional Director func.

Fixes #18327

Change-Id: I0c86d10c557254bf99fdd988227dcb15f968770b
Reviewed-on: https://go-review.googlesource.com/46716
Reviewed-by: Ian Lance Taylor <iant@golang.org>