)]}' { "commit": "f5fe0e35423125202986f3572b5b3405ce7ea904", "tree": "9935f667a1485f29b53f42a7fdb0e7cd6d588997", "parents": [ "179d09dd07d1faed24d842e84833cf207943ecda" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Oct 17 15:10:59 2017 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Oct 20 12:39:59 2017 -0400" }, "message": "[release-branch.go1.8] cmd/go: clean up x.exe properly in TestImportMain\n\nMore generally I\u0027m concerned about these tests using\n$GOROOT/src/cmd/go as scratch space, especially\ncombined wtih tg.parallel() - it\u0027s easy to believe some other\ntest might inadvertently also try to write x.exe about the\nsame time. This CL only solves the \"didn\u0027t clean up x.exe\"\nproblem and leaves for another day the \"probably shouldn\u0027t\nwrite to cmd/go at all\" problem.\n\nFixes #22266.\n\nChange-Id: I651534d70e2d360138e0373fb4a316081872550b\nReviewed-on: https://go-review.googlesource.com/71410\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "79734f90ed47f3fcedd244474d22b83f13f30a8c", "old_mode": 33188, "old_path": "src/cmd/go/go_test.go", "new_id": "a6eaef6293ac50fba4f706f32f4af9f453a17f69", "new_mode": 33188, "new_path": "src/cmd/go/go_test.go" } ] }