)]}'
{
  "commit": "e816eb50140841c524fd07ecb4eaa078954eb47c",
  "tree": "cf153a885c4ab014c38f904a60f50f47ad450890",
  "parents": [
    "7a1fce8751b04f66f758c7aac0efd5937bc670dc"
  ],
  "author": {
    "name": "Joel Sing",
    "email": "joel@sing.id.au",
    "time": "Mon Aug 28 02:08:56 2023 +1000"
  },
  "committer": {
    "name": "Joel Sing",
    "email": "joel@sing.id.au",
    "time": "Thu Nov 09 13:39:57 2023 +0000"
  },
  "message": "cmd/internal/obj/riscv: improve handling of invalid assembly\n\nCurrently, instruction validation failure will result in a panic during\nencoding. Furthermore, the errors generated do not include the PC or\nfile/line information that is normally present.\n\nFix this by:\n\n- Tracking and printing the *obj.Prog associated with the instruction,\n  including the assembly instruction/opcode if it differs. This provides\n  the standard PC and file/line prefix, which is also expected by assembly\n  error end-to-end tests.\n\n- Not proceeding with assembly if errors exist - with the current design,\n  errors are identified during validation, which is run via preprocess.\n  Attempts to encode invalid instructions will intentionally panic.\n\nAdd some additional riscv64 encoding errors, now that we can actually do so.\n\nChange-Id: I64a7b83680c4d12aebdc96c67f9df625b5ef90d3\nReviewed-on: https://go-review.googlesource.com/c/go/+/523459\nRun-TryBot: Joel Sing \u003cjoel@sing.id.au\u003e\nReviewed-by: Mark Ryan \u003cmarkdryan@rivosinc.com\u003e\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nRun-TryBot: M Zhuo \u003cmzh@golangcn.org\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nReviewed-by: M Zhuo \u003cmzh@golangcn.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "cdb8a028bd1e93b1c329ed75678f30ca900d287b",
      "old_mode": 33188,
      "old_path": "src/cmd/asm/internal/asm/testdata/riscv64error.s",
      "new_id": "2dc9db3fb1f6be9542a7a52c583fe9e18a593501",
      "new_mode": 33188,
      "new_path": "src/cmd/asm/internal/asm/testdata/riscv64error.s"
    },
    {
      "type": "modify",
      "old_id": "4ff1d910ce3aa8f1c514173b3d33130efd183721",
      "old_mode": 33188,
      "old_path": "src/cmd/internal/obj/riscv/obj.go",
      "new_id": "93bda45096148934a689cf0dfb09416f279512de",
      "new_mode": 33188,
      "new_path": "src/cmd/internal/obj/riscv/obj.go"
    }
  ]
}