cmd/compile: plumb PGO profile through inliner and body reader During inlining of instantiations of imported generic functions, the compiler reads the generic function body which can trigger CanInlineFuncs on newly instantiated functions. Currently, on this code path CanInlineFuncs is called with a nil profile, even if PGO is enabled, which causes some inconsistency. In particular, with newinliner, CanInlineFuncs calls analyzeFuncProps, which calls inlheur.AnalyzeFunc, which calls revisitInlinability, which could set fn.Inl to nil if it determined it is not inlineable (without the profile) whereas the function is actually to be inlined (because of PGO). This causes compiler crash. Fix this by plumbing the profile through. Fixes #80064. Change-Id: Ifd6b93ba4cbfae1f65334e1338ef23ef8ead0b57 Reviewed-on: https://go-review.googlesource.com/c/go/+/793042 Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.