commit df6396fc22823e9ab666d2d06c86f219d5129926
author Daniel Martí <mvdan@mvdan.cc> Fri Apr 07 18:41:10 2023 +0100
committer Gopher Robot <gobot@golang.org> Mon Apr 10 18:58:50 2023 +0000
tree 0b543bbbd423e84eb709cd6412d695b8f21d547b
parent 65ea4c5021d44395db8728eea16eb8f7fc7420eb

reflect: remove typedmemmovepartial as it is unused

It appears to have been unused since https://go.dev/cl/298670
in April 2021, as that change removed its only use.
It is always in the git history if it is needed again.

Change-Id: Ie55d059c102dfaa75bd253e09d48a4b30f45e941
Reviewed-on: https://go-review.googlesource.com/c/go/+/483136
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>

src/reflect/value.go

diff --git a/src/reflect/value.go b/src/reflect/value.go
index 5efc333..fb29769 100644
--- a/src/reflect/value.go
+++ b/src/reflect/value.go
@@ -3832,12 +3832,6 @@
 //go:noescape
 func typedmemmove(t *rtype, dst, src unsafe.Pointer)
 
-// typedmemmovepartial is like typedmemmove but assumes that
-// dst and src point off bytes into the value and only copies size bytes.
-//
-//go:noescape
-func typedmemmovepartial(t *rtype, dst, src unsafe.Pointer, off, size uintptr)
-
 // typedmemclr zeros the value at ptr of type t.
 //
 //go:noescape

src/runtime/mbarrier.go

diff --git a/src/runtime/mbarrier.go b/src/runtime/mbarrier.go
index 6d2ff22..e367d8f 100644
--- a/src/runtime/mbarrier.go
+++ b/src/runtime/mbarrier.go
@@ -217,29 +217,6 @@
 	reflect_typedmemmove(typ, dst, src)
 }
 
-// reflect_typedmemmovepartial is like typedmemmove but assumes that
-// dst and src point off bytes into the value and only copies size bytes.
-// off must be a multiple of goarch.PtrSize.
-//
-//go:linkname reflect_typedmemmovepartial reflect.typedmemmovepartial
-func reflect_typedmemmovepartial(typ *_type, dst, src unsafe.Pointer, off, size uintptr) {
-	if writeBarrier.needed && typ.ptrdata > off && size >= goarch.PtrSize {
-		if off&(goarch.PtrSize-1) != 0 {
-			panic("reflect: internal error: misaligned offset")
-		}
-		pwsize := alignDown(size, goarch.PtrSize)
-		if poff := typ.ptrdata - off; pwsize > poff {
-			pwsize = poff
-		}
-		bulkBarrierPreWrite(uintptr(dst), uintptr(src), pwsize)
-	}
-
-	memmove(dst, src, size)
-	if goexperiment.CgoCheck2 {
-		cgoCheckMemmove2(typ, dst, src, off, size)
-	}
-}
-
 // reflectcallmove is invoked by reflectcall to copy the return values
 // out of the stack and into the heap, invoking the necessary write
 // barriers. dst, src, and size describe the return value area to