more "declared and not used".
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
diff --git a/src/pkg/unicode/digit_test.go b/src/pkg/unicode/digit_test.go
index a95051f..0d5582f 100644
--- a/src/pkg/unicode/digit_test.go
+++ b/src/pkg/unicode/digit_test.go
@@ -104,12 +104,12 @@
}
func TestDigit(t *testing.T) {
- for i, r := range testDigit {
+ for _, r := range testDigit {
if !IsDigit(r) {
t.Errorf("IsDigit(U+%04X) = false, want true\n", r);
}
}
- for i, r := range testLetter {
+ for _, r := range testLetter {
if IsDigit(r) {
t.Errorf("IsDigit(U+%04X) = true, want false\n", r);
}
diff --git a/src/pkg/unicode/letter.go b/src/pkg/unicode/letter.go
index 45b68f4..2c350a1 100644
--- a/src/pkg/unicode/letter.go
+++ b/src/pkg/unicode/letter.go
@@ -54,7 +54,7 @@
func Is(ranges []Range, rune int) bool {
// common case: rune is ASCII or Latin-1
if rune < 0x100 {
- for i, r := range ranges {
+ for _, r := range ranges {
if rune > r.Hi {
continue;
}
@@ -150,7 +150,7 @@
// The characters at even offsets from the beginning of the
// sequence are upper case; the ones at odd offsets are lower.
// The correct mapping can be done by clearing or setting the low
- // bit in the sequence offset.
+ // bit in the sequence offset.
// The constants UpperCase and TitleCase are even while LowerCase
// is odd so we take the low bit from _case.
return r.Lo + ((rune - r.Lo)&^1 | _case&1);
diff --git a/src/pkg/unicode/letter_test.go b/src/pkg/unicode/letter_test.go
index b623354..3920e18 100644
--- a/src/pkg/unicode/letter_test.go
+++ b/src/pkg/unicode/letter_test.go
@@ -214,17 +214,17 @@
}
func TestIsLetter(t *testing.T) {
- for i, r := range upperTest {
+ for _, r := range upperTest {
if !IsLetter(r) {
t.Errorf("IsLetter(U+%04X) = false, want true\n", r);
}
}
- for i, r := range letterTest {
+ for _, r := range letterTest {
if !IsLetter(r) {
t.Errorf("IsLetter(U+%04X) = false, want true\n", r);
}
}
- for i, r := range notletterTest {
+ for _, r := range notletterTest {
if IsLetter(r) {
t.Errorf("IsLetter(U+%04X) = true, want false\n", r);
}
@@ -232,17 +232,17 @@
}
func TestIsUpper(t *testing.T) {
- for i, r := range upperTest {
+ for _, r := range upperTest {
if !IsUpper(r) {
t.Errorf("IsUpper(U+%04X) = false, want true\n", r);
}
}
- for i, r := range notupperTest {
+ for _, r := range notupperTest {
if IsUpper(r) {
t.Errorf("IsUpper(U+%04X) = true, want false\n", r);
}
}
- for i, r := range notletterTest {
+ for _, r := range notletterTest {
if IsUpper(r) {
t.Errorf("IsUpper(U+%04X) = true, want false\n", r);
}
@@ -262,7 +262,7 @@
}
func TestTo(t *testing.T) {
- for i, c := range caseTest {
+ for _, c := range caseTest {
r := To(c.cas, c.in);
if c.out != r {
t.Errorf("To(U+%04X, %s) = U+%04X want U+%04X\n", c.in, caseString(c.cas), r, c.out);
@@ -271,7 +271,7 @@
}
func TestToUpperCase(t *testing.T) {
- for i, c := range caseTest {
+ for _, c := range caseTest {
if c.cas != UpperCase {
continue
}
@@ -283,7 +283,7 @@
}
func TestToLowerCase(t *testing.T) {
- for i, c := range caseTest {
+ for _, c := range caseTest {
if c.cas != LowerCase {
continue
}
@@ -295,7 +295,7 @@
}
func TestToTitleCase(t *testing.T) {
- for i, c := range caseTest {
+ for _, c := range caseTest {
if c.cas != TitleCase {
continue
}
diff --git a/src/pkg/unicode/script_test.go b/src/pkg/unicode/script_test.go
index 613b569..64e205c 100644
--- a/src/pkg/unicode/script_test.go
+++ b/src/pkg/unicode/script_test.go
@@ -174,7 +174,7 @@
for k := range Scripts {
notTested[k] = true
}
- for i, test := range inTest {
+ for _, test := range inTest {
if _, ok := Scripts[test.script]; !ok {
t.Fatal(test.script, "not a known script")
}
@@ -183,7 +183,7 @@
}
notTested[test.script] = false, false
}
- for i, test := range outTest {
+ for _, test := range outTest {
if Is(Scripts[test.script], test.rune) {
t.Errorf("IsScript(%#x, %s) = true, want false\n", test.rune, test.script);
}
@@ -198,7 +198,7 @@
for k := range Categories {
notTested[k] = true
}
- for i, test := range inCategoryTest {
+ for _, test := range inCategoryTest {
if _, ok := Categories[test.script]; !ok {
t.Fatal(test.script, "not a known category")
}
@@ -217,7 +217,7 @@
for k := range Properties {
notTested[k] = true
}
- for i, test := range inPropTest {
+ for _, test := range inPropTest {
if _, ok := Properties[test.script]; !ok {
t.Fatal(test.script, "not a known prop")
}
