| commit | 9340bd610bfd386f8a71e480019b44806d53c3db | [log] [tgz] |
|---|---|---|
| author | Richard Miller <miller.research@gmail.com> | Sat Jun 13 19:04:15 2020 +0100 |
| committer | David du Colombier <0intro@gmail.com> | Sun Jun 14 17:50:11 2020 +0000 |
| tree | 51c5f43e93fe676cdc196a040cf258ccd3a9d901 | |
| parent | 97019105884ced2c4658f9763528e7f6983f8773 [diff] |
runtime: avoid lock starvation in TestNetpollBreak on Plan 9 TestNetpollBreak was sometimes timing out on Plan 9, where netpoll_stub.go implements only enough of the network poller to support runtime timers, using a notetsleep / notewakeup pair. The runtime.lock which serialises the use of the note doesn't guarantee fairness, and in practice the netpoll call used by the test can be starved by the netpoll call from the scheduler which supports the overall 'go test' timeout. Calling osyield after relinquishing the lock gives the two callers a more even chance to take a turn, which prevents the test from timing out. Fixes #39437 Change-Id: Ifbe6aaf95336d162d9d0b6deba19b8debf17b071 Reviewed-on: https://go-review.googlesource.com/c/go/+/237698 Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.