cmd/gc: complain about invalid whitespace chars
Fixes #4405.
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6855060
diff --git a/src/cmd/gc/lex.c b/src/cmd/gc/lex.c
index 1031320..ad8bdeb 100644
--- a/src/cmd/gc/lex.c
+++ b/src/cmd/gc/lex.c
@@ -99,7 +99,7 @@
static int
yy_isspace(int c)
{
- return c >= 0 && c <= 0xFF && isspace(c);
+ return c == ' ' || c == '\t' || c == '\n' || c == '\r';
}
static int
@@ -790,12 +790,8 @@
isfrog(int c)
{
// complain about possibly invisible control characters
- if(c < 0)
- return 1;
if(c < ' ') {
- if(c == '\n' || c== '\r' || c == '\t') // good white space
- return 0;
- return 1;
+ return !yy_isspace(c); // exclude good white space
}
if(0x7f <= c && c <= 0xa0) // DEL, unicode block including unbreakable space.
return 1;
diff --git a/test/fixedbugs/issue4405.go b/test/fixedbugs/issue4405.go
new file mode 100644
index 0000000..c0d8085
--- /dev/null
+++ b/test/fixedbugs/issue4405.go
@@ -0,0 +1,15 @@
+// errorcheck
+
+// Copyright 2012 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package p
+
+const (
+ _ = iota
+ _ // ERROR "illegal character"
+ _ // ERROR "illegal character"
+ _ // ERROR "illegal character"
+ _ // ERROR "illegal character"
+)
