)]}' { "commit": "6dd11bcb35cba37f5994c1b9aaaf7d2dc13fd7cf", "tree": "c04ec9e31fdca65416943a63fe70437abc674264", "parents": [ "1bc116b73ced8ec1ddc46f59acc75c89e5642607" ], "author": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Tue Jan 21 20:53:30 2020 -0800" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Fri Feb 21 02:29:11 2020 +0000" }, "message": "cmd/compile: remove chunking of rewrite rules\n\nWe added chunking of rewrite rules to speed up compiling package SSA.\nThis series of changes has significantly shrunk the number of\nrewrite rules, and they are no longer being added nearly as fast.\nNow that we are sharing v.Args across multiple rewrite rules,\nthere is additional benefit to having more rules in a single function.\nRemoving chunking now has an incidental impact on compiling package SSA,\nmarginally speeds up other compilation, shrinks the cmd/compile binary,\nand simplifies the code.\n\nname old time/op new time/op delta\nTemplate 211ms ± 2% 210ms ± 2% -0.50% (p\u003d0.000 n\u003d91+97)\nUnicode 81.9ms ± 3% 81.8ms ± 3% ~ (p\u003d0.179 n\u003d96+91)\nGoTypes 731ms ± 2% 731ms ± 1% ~ (p\u003d0.442 n\u003d94+96)\nCompiler 3.43s ± 2% 3.41s ± 2% -0.36% (p\u003d0.001 n\u003d98+94)\nSSA 8.30s ± 2% 8.32s ± 2% +0.19% (p\u003d0.034 n\u003d94+95)\nFlate 135ms ± 2% 134ms ± 1% -0.30% (p\u003d0.006 n\u003d98+94)\nGoParser 167ms ± 1% 167ms ± 1% -0.22% (p\u003d0.001 n\u003d92+94)\nReflect 453ms ± 2% 453ms ± 3% ~ (p\u003d0.306 n\u003d98+97)\nTar 184ms ± 2% 183ms ± 2% -0.31% (p\u003d0.012 n\u003d94+94)\nXML 249ms ± 2% 248ms ± 1% -0.26% (p\u003d0.002 n\u003d96+92)\n[Geo mean] 419ms 418ms -0.21%\n\nname old user-time/op new user-time/op delta\nTemplate 273ms ± 2% 272ms ± 2% -0.46% (p\u003d0.000 n\u003d93+96)\nUnicode 116ms ± 4% 117ms ± 4% ~ (p\u003d0.433 n\u003d98+98)\nGoTypes 977ms ± 2% 977ms ± 1% ~ (p\u003d0.971 n\u003d92+99)\nCompiler 4.56s ± 6% 4.53s ± 6% ~ (p\u003d0.081 n\u003d100+100)\nSSA 11.1s ± 2% 11.1s ± 2% ~ (p\u003d0.064 n\u003d99+96)\nFlate 167ms ± 2% 167ms ± 1% -0.24% (p\u003d0.004 n\u003d95+96)\nGoParser 203ms ± 1% 203ms ± 2% -0.14% (p\u003d0.049 n\u003d96+97)\nReflect 595ms ± 2% 595ms ± 2% ~ (p\u003d0.544 n\u003d95+92)\nTar 225ms ± 2% 224ms ± 2% ~ (p\u003d0.562 n\u003d99+99)\nXML 312ms ± 2% 311ms ± 1% ~ (p\u003d0.050 n\u003d97+93)\n[Geo mean] 543ms 542ms -0.13%\n\nChange-Id: I8d34ab59f154b28f20c6f9e416b976bfce339baa\nReviewed-on: https://go-review.googlesource.com/c/go/+/216220\nRun-TryBot: Josh Bleecher Snyder \u003cjosharian@gmail.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "f1cfa1824a076a90976234153d793038384c6fdb", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/gen/rulegen.go", "new_id": "2e5f3d24f3dac295e558410c1d8de2bb27d13153", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/gen/rulegen.go" }, { "type": "modify", "old_id": "35de8bcd91276716546d6e2ca11e4fc645be915f", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewrite386.go", "new_id": "02716a3e30cca781e14849e4f2cfd21157a14223", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewrite386.go" }, { "type": "modify", "old_id": "9f1c71aa1832b297c0231043eaeedf3081f14818", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewrite386splitload.go", "new_id": "cce1b2d05acfb36d791d266ff966ebbc8b246479", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewrite386splitload.go" }, { "type": "modify", "old_id": "3c2e57b1c3e310a095233d9e5facc0da1d5aa04a", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewriteAMD64.go", "new_id": "df9f0d0f345ee0febce7e342578f0358039ab2fe", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewriteAMD64.go" }, { "type": "modify", "old_id": "ec7d2270b36fd0be9fc68395ee9c5bf5fe823f25", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewriteAMD64splitload.go", "new_id": "69df3f7a1e547934f23618156b46a07fadd1e6ed", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewriteAMD64splitload.go" }, { "type": "modify", "old_id": "76befe077b2bb22f124700241060328f33aeeb79", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewriteARM.go", "new_id": "c864f1e0f34b800cdfff522696cfd1c53f95e06a", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewriteARM.go" }, { "type": "modify", "old_id": "87e15d911a356935b069bf272fd296f74fd2d324", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewriteARM64.go", "new_id": "6e69eabe47c1f0a264e1d6980ecf22c8a372a164", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewriteARM64.go" }, { "type": "modify", "old_id": "47adca632ebcaa6cc8d05acc4e081d2442f736e6", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewriteMIPS.go", "new_id": "3058ecb677d5327fa5685cb99e9096d724bd45f8", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewriteMIPS.go" }, { "type": "modify", "old_id": "7657eef13d990703ff168c294d46e53edcdee3c3", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewriteMIPS64.go", "new_id": "58d556779f8e7c654801d3b06fa720ae9ab0d8f9", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewriteMIPS64.go" }, { "type": "modify", "old_id": "9ac9cf3aef68b0dd931768ab5f97d302fd569e8d", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewritePPC64.go", "new_id": "12fdcae275804aea0173f0f6d43242e992b641b6", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewritePPC64.go" }, { "type": "modify", "old_id": "5e5c472aabef72185e3de25a50e2f518a2812853", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewriteRISCV64.go", "new_id": "d7b92c51b67572c27a2a1ea6613636a8033d6177", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewriteRISCV64.go" }, { "type": "modify", "old_id": "d2b917204b9356db0d67e7f36a5e795355f9c148", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewriteS390X.go", "new_id": "f396babee3bf7f7f2deba54d0d57f72bce29f928", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewriteS390X.go" }, { "type": "modify", "old_id": "5993e9bed16c5f8a5dfff078b9b81a5bc2066eca", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewriteWasm.go", "new_id": "53d03ad0ca7f81de7dda218a4cd593d66a1bf876", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewriteWasm.go" }, { "type": "modify", "old_id": "1d1dac7866a1c5a13cd03f141fb4ed6d31a02360", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewritedec.go", "new_id": "9393cade620ecdab95665d517d681f363f849b6a", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewritedec.go" }, { "type": "modify", "old_id": "28b3ab745b32e82e60f27160b2c50afaeeb14244", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewritedec64.go", "new_id": "f518ffcd3abd5febc24190755b1dbb11b89dbd19", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewritedec64.go" }, { "type": "modify", "old_id": "0f6d01f22b87517fd9f0345031cab10465edb90a", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewritedecArgs.go", "new_id": "9a9e522554616c44ce9f77300f999bd99a3894a1", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewritedecArgs.go" }, { "type": "modify", "old_id": "ea0d92c81b78d18f9352684a12680e6ddaa4f56d", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/rewritegeneric.go", "new_id": "9d88652d4a56c2b8e9a4648b20018d10b4e702fb", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/rewritegeneric.go" } ] }