src/cmd/go/internal/mvs/mvs.go - go - Git at Google

 // Copyright 2018 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.

 // Package mvs implements Minimal Version Selection.
 // See https://research.swtch.com/vgo-mvs.
 package mvs

 import (
 	"fmt"
 	"sort"
 	"sync"

 	"cmd/go/internal/par"

 	"golang.org/x/mod/module"
 )

 // A Reqs is the requirement graph on which Minimal Version Selection (MVS) operates.
 //
 // The version strings are opaque except for the special version "none"
 // (see the documentation for module.Version). In particular, MVS does not
 // assume that the version strings are semantic versions; instead, the Max method
 // gives access to the comparison operation.
 //
 // It must be safe to call methods on a Reqs from multiple goroutines simultaneously.
 // Because a Reqs may read the underlying graph from the network on demand,
 // the MVS algorithms parallelize the traversal to overlap network delays.
 type Reqs interface {
 	// Required returns the module versions explicitly required by m itself.
 	// The caller must not modify the returned list.
 	Required(m module.Version) ([]module.Version, error)

 	// Max returns the maximum of v1 and v2 (it returns either v1 or v2).
 	//
 	// For all versions v, Max(v, "none") must be v,
 	// and for the target passed as the first argument to MVS functions,
 	// Max(target, v) must be target.
 	//
 	// Note that v1 < v2 can be written Max(v1, v2) != v1
 	// and similarly v1 <= v2 can be written Max(v1, v2) == v2.
 	Max(v1, v2 string) string
 }

 // An UpgradeReqs is a Reqs that can also identify available upgrades.
 type UpgradeReqs interface {
 	Reqs

 	// Upgrade returns the upgraded version of m,
 	// for use during an UpgradeAll operation.
 	// If m should be kept as is, Upgrade returns m.
 	// If m is not yet used in the build, then m.Version will be "none".
 	// More typically, m.Version will be the version required
 	// by some other module in the build.
 	//
 	// If no module version is available for the given path,
 	// Upgrade returns a non-nil error.
 	// TODO(rsc): Upgrade must be able to return errors,
 	// but should "no latest version" just return m instead?
 	Upgrade(m module.Version) (module.Version, error)
 }

 // A DowngradeReqs is a Reqs that can also identify available downgrades.
 type DowngradeReqs interface {
 	Reqs

 	// Previous returns the version of m.Path immediately prior to m.Version,
 	// or "none" if no such version is known.
 	Previous(m module.Version) (module.Version, error)
 }

 // BuildList returns the build list for the target module.
 //
 // target is the root vertex of a module requirement graph. For cmd/go, this is
 // typically the main module, but note that this algorithm is not intended to
 // be Go-specific: module paths and versions are treated as opaque values.
 //
 // reqs describes the module requirement graph and provides an opaque method
 // for comparing versions.
 //
 // BuildList traverses the graph and returns a list containing the highest
 // version for each visited module. The first element of the returned list is
 // target itself; reqs.Max requires target.Version to compare higher than all
 // other versions, so no other version can be selected. The remaining elements
 // of the list are sorted by path.
 //
 // See https://research.swtch.com/vgo-mvs for details.
 func BuildList(target module.Version, reqs Reqs) ([]module.Version, error) {
 	return buildList(target, reqs, nil)
 }

 func buildList(target module.Version, reqs Reqs, upgrade func(module.Version) (module.Version, error)) ([]module.Version, error) {
 	cmp := func(v1, v2 string) int {
 		if reqs.Max(v1, v2) != v1 {
 			return -1
 		}
 		if reqs.Max(v2, v1) != v2 {
 			return 1
 		}
 		return 0
 	}

 	var (
 		mu       sync.Mutex
 		g        = NewGraph(cmp, []module.Version{target})
 		upgrades = map[module.Version]module.Version{}
 		errs     = map[module.Version]error{} // (non-nil errors only)
 	)

 	// Explore work graph in parallel in case reqs.Required
 	// does high-latency network operations.
 	var work par.Work
 	work.Add(target)
 	work.Do(10, func(item interface{}) {
 		m := item.(module.Version)

 		var required []module.Version
 		var err error
 		if m.Version != "none" {
 			required, err = reqs.Required(m)
 		}

 		u := m
 		if upgrade != nil {
 			upgradeTo, upErr := upgrade(m)
 			if upErr == nil {
 				u = upgradeTo
 			} else if err == nil {
 				err = upErr
 			}
 		}

 		mu.Lock()
 		if err != nil {
 			errs[m] = err
 		}
 		if u != m {
 			upgrades[m] = u
 			required = append([]module.Version{u}, required...)
 		}
 		g.Require(m, required)
 		mu.Unlock()

 		for _, r := range required {
 			work.Add(r)
 		}
 	})

 	// If there was an error, find the shortest path from the target to the
 	// node where the error occurred so we can report a useful error message.
 	if len(errs) > 0 {
 		errPath := g.FindPath(func(m module.Version) bool {
 			return errs[m] != nil
 		})
 		if len(errPath) == 0 {
 			panic("internal error: could not reconstruct path to module with error")
 		}

 		err := errs[errPath[len(errPath)-1]]
 		isUpgrade := func(from, to module.Version) bool {
 			if u, ok := upgrades[from]; ok {
 				return u == to
 			}
 			return false
 		}
 		return nil, NewBuildListError(err.(error), errPath, isUpgrade)
 	}

 	// The final list is the minimum version of each module found in the graph.
 	list := g.BuildList()
 	if v := list[0]; v != target {
 		// target.Version will be "" for modload, the main client of MVS.
 		// "" denotes the main module, which has no version. However, MVS treats
 		// version strings as opaque, so "" is not a special value here.
 		// See golang.org/issue/31491, golang.org/issue/29773.
 		panic(fmt.Sprintf("mistake: chose version %q instead of target %+v", v, target))
 	}
 	return list, nil
 }

 // Req returns the minimal requirement list for the target module,
 // with the constraint that all module paths listed in base must
 // appear in the returned list.
 func Req(target module.Version, base []string, reqs Reqs) ([]module.Version, error) {
 	list, err := BuildList(target, reqs)
 	if err != nil {
 		return nil, err
 	}

 	// Note: Not running in parallel because we assume
 	// that list came from a previous operation that paged
 	// in all the requirements, so there's no I/O to overlap now.

 	// Compute postorder, cache requirements.
 	var postorder []module.Version
 	reqCache := map[module.Version][]module.Version{}
 	reqCache[target] = nil
 	var walk func(module.Version) error
 	walk = func(m module.Version) error {
 		_, ok := reqCache[m]
 		if ok {
 			return nil
 		}
 		required, err := reqs.Required(m)
 		if err != nil {
 			return err
 		}
 		reqCache[m] = required
 		for _, m1 := range required {
 			if err := walk(m1); err != nil {
 				return err
 			}
 		}
 		postorder = append(postorder, m)
 		return nil
 	}
 	for _, m := range list {
 		if err := walk(m); err != nil {
 			return nil, err
 		}
 	}

 	// Walk modules in reverse post-order, only adding those not implied already.
 	have := map[module.Version]bool{}
 	walk = func(m module.Version) error {
 		if have[m] {
 			return nil
 		}
 		have[m] = true
 		for _, m1 := range reqCache[m] {
 			walk(m1)
 		}
 		return nil
 	}
 	max := map[string]string{}
 	for _, m := range list {
 		if v, ok := max[m.Path]; ok {
 			max[m.Path] = reqs.Max(m.Version, v)
 		} else {
 			max[m.Path] = m.Version
 		}
 	}
 	// First walk the base modules that must be listed.
 	var min []module.Version
 	haveBase := map[string]bool{}
 	for _, path := range base {
 		if haveBase[path] {
 			continue
 		}
 		m := module.Version{Path: path, Version: max[path]}
 		min = append(min, m)
 		walk(m)
 		haveBase[path] = true
 	}
 	// Now the reverse postorder to bring in anything else.
 	for i := len(postorder) - 1; i >= 0; i-- {
 		m := postorder[i]
 		if max[m.Path] != m.Version {
 			// Older version.
 			continue
 		}
 		if !have[m] {
 			min = append(min, m)
 			walk(m)
 		}
 	}
 	sort.Slice(min, func(i, j int) bool {
 		return min[i].Path < min[j].Path
 	})
 	return min, nil
 }

 // UpgradeAll returns a build list for the target module
 // in which every module is upgraded to its latest version.
 func UpgradeAll(target module.Version, reqs UpgradeReqs) ([]module.Version, error) {
 	return buildList(target, reqs, func(m module.Version) (module.Version, error) {
 		if m.Path == target.Path {
 			return target, nil
 		}

 		return reqs.Upgrade(m)
 	})
 }

 // Upgrade returns a build list for the target module
 // in which the given additional modules are upgraded.
 func Upgrade(target module.Version, reqs UpgradeReqs, upgrade ...module.Version) ([]module.Version, error) {
 	list, err := reqs.Required(target)
 	if err != nil {
 		return nil, err
 	}

 	pathInList := make(map[string]bool, len(list))
 	for _, m := range list {
 		pathInList[m.Path] = true
 	}
 	list = append([]module.Version(nil), list...)

 	upgradeTo := make(map[string]string, len(upgrade))
 	for _, u := range upgrade {
 		if !pathInList[u.Path] {
 			list = append(list, module.Version{Path: u.Path, Version: "none"})
 		}
 		if prev, dup := upgradeTo[u.Path]; dup {
 			upgradeTo[u.Path] = reqs.Max(prev, u.Version)
 		} else {
 			upgradeTo[u.Path] = u.Version
 		}
 	}

 	return buildList(target, &override{target, list, reqs}, func(m module.Version) (module.Version, error) {
 		if v, ok := upgradeTo[m.Path]; ok {
 			return module.Version{Path: m.Path, Version: v}, nil
 		}
 		return m, nil
 	})
 }

 // Downgrade returns a build list for the target module
 // in which the given additional modules are downgraded,
 // potentially overriding the requirements of the target.
 //
 // The versions to be downgraded may be unreachable from reqs.Latest and
 // reqs.Previous, but the methods of reqs must otherwise handle such versions
 // correctly.
 func Downgrade(target module.Version, reqs DowngradeReqs, downgrade ...module.Version) ([]module.Version, error) {
 	// Per https://research.swtch.com/vgo-mvs#algorithm_4:
 	// “To avoid an unnecessary downgrade to E 1.1, we must also add a new
 	// requirement on E 1.2. We can apply Algorithm R to find the minimal set of
 	// new requirements to write to go.mod.”
 	//
 	// In order to generate those new requirements, we need to identify versions
 	// for every module in the build list — not just reqs.Required(target).
 	list, err := BuildList(target, reqs)
 	if err != nil {
 		return nil, err
 	}
 	list = list[1:] // remove target

 	max := make(map[string]string)
 	for _, r := range list {
 		max[r.Path] = r.Version
 	}
 	for _, d := range downgrade {
 		if v, ok := max[d.Path]; !ok || reqs.Max(v, d.Version) != d.Version {
 			max[d.Path] = d.Version
 		}
 	}

 	var (
 		added    = make(map[module.Version]bool)
 		rdeps    = make(map[module.Version][]module.Version)
 		excluded = make(map[module.Version]bool)
 	)
 	var exclude func(module.Version)
 	exclude = func(m module.Version) {
 		if excluded[m] {
 			return
 		}
 		excluded[m] = true
 		for _, p := range rdeps[m] {
 			exclude(p)
 		}
 	}
 	var add func(module.Version)
 	add = func(m module.Version) {
 		if added[m] {
 			return
 		}
 		added[m] = true
 		if v, ok := max[m.Path]; ok && reqs.Max(m.Version, v) != v {
 			// m would upgrade an existing dependency — it is not a strict downgrade,
 			// and because it was already present as a dependency, it could affect the
 			// behavior of other relevant packages.
 			exclude(m)
 			return
 		}
 		list, err := reqs.Required(m)
 		if err != nil {
 			// If we can't load the requirements, we couldn't load the go.mod file.
 			// There are a number of reasons this can happen, but this usually
 			// means an older version of the module had a missing or invalid
 			// go.mod file. For example, if example.com/mod released v2.0.0 before
 			// migrating to modules (v2.0.0+incompatible), then added a valid go.mod
 			// in v2.0.1, downgrading from v2.0.1 would cause this error.
 			//
 			// TODO(golang.org/issue/31730, golang.org/issue/30134): if the error
 			// is transient (we couldn't download go.mod), return the error from
 			// Downgrade. Currently, we can't tell what kind of error it is.
 			exclude(m)
 			return
 		}
 		for _, r := range list {
 			add(r)
 			if excluded[r] {
 				exclude(m)
 				return
 			}
 			rdeps[r] = append(rdeps[r], m)
 		}
 	}

 	downgraded := make([]module.Version, 0, len(list)+1)
 	downgraded = append(downgraded, target)
 List:
 	for _, r := range list {
 		add(r)
 		for excluded[r] {
 			p, err := reqs.Previous(r)
 			if err != nil {
 				// This is likely a transient error reaching the repository,
 				// rather than a permanent error with the retrieved version.
 				//
 				// TODO(golang.org/issue/31730, golang.org/issue/30134):
 				// decode what to do based on the actual error.
 				return nil, err
 			}
 			// If the target version is a pseudo-version, it may not be
 			// included when iterating over prior versions using reqs.Previous.
 			// Insert it into the right place in the iteration.
 			// If v is excluded, p should be returned again by reqs.Previous on the next iteration.
 			if v := max[r.Path]; reqs.Max(v, r.Version) != v && reqs.Max(p.Version, v) != p.Version {
 				p.Version = v
 			}
 			if p.Version == "none" {
 				continue List
 			}
 			add(p)
 			r = p
 		}
 		downgraded = append(downgraded, r)
 	}

 	// The downgrades we computed above only downgrade to versions enumerated by
 	// reqs.Previous. However, reqs.Previous omits some versions — such as
 	// pseudo-versions and retracted versions — that may be selected as transitive
 	// requirements of other modules.
 	//
 	// If one of those requirements pulls the version back up above the version
 	// identified by reqs.Previous, then the transitive dependencies of that that
 	// initially-downgraded version should no longer matter — in particular, we
 	// should not add new dependencies on module paths that nothing else in the
 	// updated module graph even requires.
 	//
 	// In order to eliminate those spurious dependencies, we recompute the build
 	// list with the actual versions of the downgraded modules as selected by MVS,
 	// instead of our initial downgrades.
 	// (See the downhiddenartifact and downhiddencross test cases).
 	actual, err := BuildList(target, &override{
 		target: target,
 		list:   downgraded,
 		Reqs:   reqs,
 	})
 	if err != nil {
 		return nil, err
 	}
 	actualVersion := make(map[string]string, len(actual))
 	for _, m := range actual {
 		actualVersion[m.Path] = m.Version
 	}

 	downgraded = downgraded[:0]
 	for _, m := range list {
 		if v, ok := actualVersion[m.Path]; ok {
 			downgraded = append(downgraded, module.Version{Path: m.Path, Version: v})
 		}
 	}

 	return BuildList(target, &override{
 		target: target,
 		list:   downgraded,
 		Reqs:   reqs,
 	})
 }

 type override struct {
 	target module.Version
 	list   []module.Version
 	Reqs
 }

 func (r *override) Required(m module.Version) ([]module.Version, error) {
 	if m == r.target {
 		return r.list, nil
 	}
 	return r.Reqs.Required(m)
 }
	// Copyright 2018 The Go Authors. All rights reserved.
	// Use of this source code is governed by a BSD-style
	// license that can be found in the LICENSE file.

	// Package mvs implements Minimal Version Selection.
	// See https://research.swtch.com/vgo-mvs.
	package mvs

	import (
	"fmt"
	"sort"
	"sync"

	"cmd/go/internal/par"

	"golang.org/x/mod/module"
	)

	// A Reqs is the requirement graph on which Minimal Version Selection (MVS) operates.
	//
	// The version strings are opaque except for the special version "none"
	// (see the documentation for module.Version). In particular, MVS does not
	// assume that the version strings are semantic versions; instead, the Max method
	// gives access to the comparison operation.
	//
	// It must be safe to call methods on a Reqs from multiple goroutines simultaneously.
	// Because a Reqs may read the underlying graph from the network on demand,
	// the MVS algorithms parallelize the traversal to overlap network delays.
	type Reqs interface {
	// Required returns the module versions explicitly required by m itself.
	// The caller must not modify the returned list.
	Required(m module.Version) ([]module.Version, error)

	// Max returns the maximum of v1 and v2 (it returns either v1 or v2).
	//
	// For all versions v, Max(v, "none") must be v,
	// and for the target passed as the first argument to MVS functions,
	// Max(target, v) must be target.
	//
	// Note that v1 < v2 can be written Max(v1, v2) != v1
	// and similarly v1 <= v2 can be written Max(v1, v2) == v2.
	Max(v1, v2 string) string
	}

	// An UpgradeReqs is a Reqs that can also identify available upgrades.
	type UpgradeReqs interface {
	Reqs

	// Upgrade returns the upgraded version of m,
	// for use during an UpgradeAll operation.
	// If m should be kept as is, Upgrade returns m.
	// If m is not yet used in the build, then m.Version will be "none".
	// More typically, m.Version will be the version required
	// by some other module in the build.
	//
	// If no module version is available for the given path,
	// Upgrade returns a non-nil error.
	// TODO(rsc): Upgrade must be able to return errors,
	// but should "no latest version" just return m instead?
	Upgrade(m module.Version) (module.Version, error)
	}

	// A DowngradeReqs is a Reqs that can also identify available downgrades.
	type DowngradeReqs interface {
	Reqs

	// Previous returns the version of m.Path immediately prior to m.Version,
	// or "none" if no such version is known.
	Previous(m module.Version) (module.Version, error)
	}

	// BuildList returns the build list for the target module.
	//
	// target is the root vertex of a module requirement graph. For cmd/go, this is
	// typically the main module, but note that this algorithm is not intended to
	// be Go-specific: module paths and versions are treated as opaque values.
	//
	// reqs describes the module requirement graph and provides an opaque method
	// for comparing versions.
	//
	// BuildList traverses the graph and returns a list containing the highest
	// version for each visited module. The first element of the returned list is
	// target itself; reqs.Max requires target.Version to compare higher than all
	// other versions, so no other version can be selected. The remaining elements
	// of the list are sorted by path.
	//
	// See https://research.swtch.com/vgo-mvs for details.
	func BuildList(target module.Version, reqs Reqs) ([]module.Version, error) {
	return buildList(target, reqs, nil)
	}

	func buildList(target module.Version, reqs Reqs, upgrade func(module.Version) (module.Version, error)) ([]module.Version, error) {
	cmp := func(v1, v2 string) int {
	if reqs.Max(v1, v2) != v1 {
	return -1
	}
	if reqs.Max(v2, v1) != v2 {
	return 1
	}
	return 0
	}

	var (
	mu sync.Mutex
	g = NewGraph(cmp, []module.Version{target})
	upgrades = map[module.Version]module.Version{}
	errs = map[module.Version]error{} // (non-nil errors only)
	)

	// Explore work graph in parallel in case reqs.Required
	// does high-latency network operations.
	var work par.Work
	work.Add(target)
	work.Do(10, func(item interface{}) {
	m := item.(module.Version)

	var required []module.Version
	var err error
	if m.Version != "none" {
	required, err = reqs.Required(m)
	}

	u := m
	if upgrade != nil {
	upgradeTo, upErr := upgrade(m)
	if upErr == nil {
	u = upgradeTo
	} else if err == nil {
	err = upErr
	}
	}

	mu.Lock()
	if err != nil {
	errs[m] = err
	}
	if u != m {
	upgrades[m] = u
	required = append([]module.Version{u}, required...)
	}
	g.Require(m, required)
	mu.Unlock()

	for _, r := range required {
	work.Add(r)
	}
	})

	// If there was an error, find the shortest path from the target to the
	// node where the error occurred so we can report a useful error message.
	if len(errs) > 0 {
	errPath := g.FindPath(func(m module.Version) bool {
	return errs[m] != nil
	})
	if len(errPath) == 0 {
	panic("internal error: could not reconstruct path to module with error")
	}

	err := errs[errPath[len(errPath)-1]]
	isUpgrade := func(from, to module.Version) bool {
	if u, ok := upgrades[from]; ok {
	return u == to
	}
	return false
	}
	return nil, NewBuildListError(err.(error), errPath, isUpgrade)
	}

	// The final list is the minimum version of each module found in the graph.
	list := g.BuildList()
	if v := list[0]; v != target {
	// target.Version will be "" for modload, the main client of MVS.
	// "" denotes the main module, which has no version. However, MVS treats
	// version strings as opaque, so "" is not a special value here.
	// See golang.org/issue/31491, golang.org/issue/29773.
	panic(fmt.Sprintf("mistake: chose version %q instead of target %+v", v, target))
	}
	return list, nil
	}

	// Req returns the minimal requirement list for the target module,
	// with the constraint that all module paths listed in base must
	// appear in the returned list.
	func Req(target module.Version, base []string, reqs Reqs) ([]module.Version, error) {
	list, err := BuildList(target, reqs)
	if err != nil {
	return nil, err
	}

	// Note: Not running in parallel because we assume
	// that list came from a previous operation that paged
	// in all the requirements, so there's no I/O to overlap now.

	// Compute postorder, cache requirements.
	var postorder []module.Version
	reqCache := map[module.Version][]module.Version{}
	reqCache[target] = nil
	var walk func(module.Version) error
	walk = func(m module.Version) error {
	_, ok := reqCache[m]
	if ok {
	return nil
	}
	required, err := reqs.Required(m)
	if err != nil {
	return err
	}
	reqCache[m] = required
	for _, m1 := range required {
	if err := walk(m1); err != nil {
	return err
	}
	}
	postorder = append(postorder, m)
	return nil
	}
	for _, m := range list {
	if err := walk(m); err != nil {
	return nil, err
	}
	}

	// Walk modules in reverse post-order, only adding those not implied already.
	have := map[module.Version]bool{}
	walk = func(m module.Version) error {
	if have[m] {
	return nil
	}
	have[m] = true
	for _, m1 := range reqCache[m] {
	walk(m1)
	}
	return nil
	}
	max := map[string]string{}
	for _, m := range list {
	if v, ok := max[m.Path]; ok {
	max[m.Path] = reqs.Max(m.Version, v)
	} else {
	max[m.Path] = m.Version
	}
	}
	// First walk the base modules that must be listed.
	var min []module.Version
	haveBase := map[string]bool{}
	for _, path := range base {
	if haveBase[path] {
	continue
	}
	m := module.Version{Path: path, Version: max[path]}
	min = append(min, m)
	walk(m)
	haveBase[path] = true
	}
	// Now the reverse postorder to bring in anything else.
	for i := len(postorder) - 1; i >= 0; i-- {
	m := postorder[i]
	if max[m.Path] != m.Version {
	// Older version.
	continue
	}
	if !have[m] {
	min = append(min, m)
	walk(m)
	}
	}
	sort.Slice(min, func(i, j int) bool {
	return min[i].Path < min[j].Path
	})
	return min, nil
	}

	// UpgradeAll returns a build list for the target module
	// in which every module is upgraded to its latest version.
	func UpgradeAll(target module.Version, reqs UpgradeReqs) ([]module.Version, error) {
	return buildList(target, reqs, func(m module.Version) (module.Version, error) {
	if m.Path == target.Path {
	return target, nil
	}

	return reqs.Upgrade(m)
	})
	}

	// Upgrade returns a build list for the target module
	// in which the given additional modules are upgraded.
	func Upgrade(target module.Version, reqs UpgradeReqs, upgrade ...module.Version) ([]module.Version, error) {
	list, err := reqs.Required(target)
	if err != nil {
	return nil, err
	}

	pathInList := make(map[string]bool, len(list))
	for _, m := range list {
	pathInList[m.Path] = true
	}
	list = append([]module.Version(nil), list...)

	upgradeTo := make(map[string]string, len(upgrade))
	for _, u := range upgrade {
	if !pathInList[u.Path] {
	list = append(list, module.Version{Path: u.Path, Version: "none"})
	}
	if prev, dup := upgradeTo[u.Path]; dup {
	upgradeTo[u.Path] = reqs.Max(prev, u.Version)
	} else {
	upgradeTo[u.Path] = u.Version
	}
	}

	return buildList(target, &override{target, list, reqs}, func(m module.Version) (module.Version, error) {
	if v, ok := upgradeTo[m.Path]; ok {
	return module.Version{Path: m.Path, Version: v}, nil
	}
	return m, nil
	})
	}

	// Downgrade returns a build list for the target module
	// in which the given additional modules are downgraded,
	// potentially overriding the requirements of the target.
	//
	// The versions to be downgraded may be unreachable from reqs.Latest and
	// reqs.Previous, but the methods of reqs must otherwise handle such versions
	// correctly.
	func Downgrade(target module.Version, reqs DowngradeReqs, downgrade ...module.Version) ([]module.Version, error) {
	// Per https://research.swtch.com/vgo-mvs#algorithm_4:
	// “To avoid an unnecessary downgrade to E 1.1, we must also add a new
	// requirement on E 1.2. We can apply Algorithm R to find the minimal set of
	// new requirements to write to go.mod.”
	//
	// In order to generate those new requirements, we need to identify versions
	// for every module in the build list — not just reqs.Required(target).
	list, err := BuildList(target, reqs)
	if err != nil {
	return nil, err
	}
	list = list[1:] // remove target

	max := make(map[string]string)
	for _, r := range list {
	max[r.Path] = r.Version
	}
	for _, d := range downgrade {
	if v, ok := max[d.Path]; !ok \|\| reqs.Max(v, d.Version) != d.Version {
	max[d.Path] = d.Version
	}
	}

	var (
	added = make(map[module.Version]bool)
	rdeps = make(map[module.Version][]module.Version)
	excluded = make(map[module.Version]bool)
	)
	var exclude func(module.Version)
	exclude = func(m module.Version) {
	if excluded[m] {
	return
	}
	excluded[m] = true
	for _, p := range rdeps[m] {
	exclude(p)
	}
	}
	var add func(module.Version)
	add = func(m module.Version) {
	if added[m] {
	return
	}
	added[m] = true
	if v, ok := max[m.Path]; ok && reqs.Max(m.Version, v) != v {
	// m would upgrade an existing dependency — it is not a strict downgrade,
	// and because it was already present as a dependency, it could affect the
	// behavior of other relevant packages.
	exclude(m)
	return
	}
	list, err := reqs.Required(m)
	if err != nil {
	// If we can't load the requirements, we couldn't load the go.mod file.
	// There are a number of reasons this can happen, but this usually
	// means an older version of the module had a missing or invalid
	// go.mod file. For example, if example.com/mod released v2.0.0 before
	// migrating to modules (v2.0.0+incompatible), then added a valid go.mod
	// in v2.0.1, downgrading from v2.0.1 would cause this error.
	//
	// TODO(golang.org/issue/31730, golang.org/issue/30134): if the error
	// is transient (we couldn't download go.mod), return the error from
	// Downgrade. Currently, we can't tell what kind of error it is.
	exclude(m)
	return
	}
	for _, r := range list {
	add(r)
	if excluded[r] {
	exclude(m)
	return
	}
	rdeps[r] = append(rdeps[r], m)
	}
	}

	downgraded := make([]module.Version, 0, len(list)+1)
	downgraded = append(downgraded, target)
	List:
	for _, r := range list {
	add(r)
	for excluded[r] {
	p, err := reqs.Previous(r)
	if err != nil {
	// This is likely a transient error reaching the repository,
	// rather than a permanent error with the retrieved version.
	//
	// TODO(golang.org/issue/31730, golang.org/issue/30134):
	// decode what to do based on the actual error.
	return nil, err
	}
	// If the target version is a pseudo-version, it may not be
	// included when iterating over prior versions using reqs.Previous.
	// Insert it into the right place in the iteration.
	// If v is excluded, p should be returned again by reqs.Previous on the next iteration.
	if v := max[r.Path]; reqs.Max(v, r.Version) != v && reqs.Max(p.Version, v) != p.Version {
	p.Version = v
	}
	if p.Version == "none" {
	continue List
	}
	add(p)
	r = p
	}
	downgraded = append(downgraded, r)
	}

	// The downgrades we computed above only downgrade to versions enumerated by
	// reqs.Previous. However, reqs.Previous omits some versions — such as
	// pseudo-versions and retracted versions — that may be selected as transitive
	// requirements of other modules.
	//
	// If one of those requirements pulls the version back up above the version
	// identified by reqs.Previous, then the transitive dependencies of that that
	// initially-downgraded version should no longer matter — in particular, we
	// should not add new dependencies on module paths that nothing else in the
	// updated module graph even requires.
	//
	// In order to eliminate those spurious dependencies, we recompute the build
	// list with the actual versions of the downgraded modules as selected by MVS,
	// instead of our initial downgrades.
	// (See the downhiddenartifact and downhiddencross test cases).
	actual, err := BuildList(target, &override{
	target: target,
	list: downgraded,
	Reqs: reqs,
	})
	if err != nil {
	return nil, err
	}
	actualVersion := make(map[string]string, len(actual))
	for _, m := range actual {
	actualVersion[m.Path] = m.Version
	}

	downgraded = downgraded[:0]
	for _, m := range list {
	if v, ok := actualVersion[m.Path]; ok {
	downgraded = append(downgraded, module.Version{Path: m.Path, Version: v})
	}
	}

	return BuildList(target, &override{
	target: target,
	list: downgraded,
	Reqs: reqs,
	})
	}

	type override struct {
	target module.Version
	list []module.Version
	Reqs
	}

	func (r *override) Required(m module.Version) ([]module.Version, error) {
	if m == r.target {
	return r.list, nil
	}
	return r.Reqs.Required(m)
	}