runtime: lock M for the entire fast path In size-specialized malloc, the fast path assumes that GC marking is not occurring. Thus once we decide to take the fast path, we must guarantee that the GC cannot start. No such guarantee exists today because the forceSlowPath check occurs outside of any locking. This may not have any impact on normal builds because we don't async preempt the runtime, and I'm not sure there are any preemptible calls before acquirem. But when inlining is disabled, there are preemptible calls which could thus allow a GC cycle to start. Fix this by calling acquirem prior to the forceSlowPath check and holding it through inlinedStub. Note that the slow path takes acquirem a bit later because we must not acquirem before deductAssistCredit, as that function won't run any assists when locked. For #79667. For #79699. Change-Id: Ief7220435b6a5fd70d721f58cbeac86e6a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/794121 Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.