cmd/compile: clean up store rules to use store type, not argument type
Argument type is dangerous because it may be thinner than the actual
store being issued.
Change-Id: Id19fbd8e6c41390a453994f897dd5048473136aa
Reviewed-on: https://go-review.googlesource.com/c/go/+/483438
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: David Chase <drchase@google.com>
diff --git a/src/cmd/compile/internal/ssa/_gen/386.rules b/src/cmd/compile/internal/ssa/_gen/386.rules
index 03413b2..9abc981 100644
--- a/src/cmd/compile/internal/ssa/_gen/386.rules
+++ b/src/cmd/compile/internal/ssa/_gen/386.rules
@@ -206,11 +206,9 @@
(Load <t> ptr mem) && is64BitFloat(t) => (MOVSDload ptr mem)
// Lowering stores
-// These more-specific FP versions of Store pattern should come first.
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (MOVSDstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (MOVSSstore ptr val mem)
-
-(Store {t} ptr val mem) && t.Size() == 4 => (MOVLstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (MOVSDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (MOVSSstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVLstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVWstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
diff --git a/src/cmd/compile/internal/ssa/_gen/AMD64.rules b/src/cmd/compile/internal/ssa/_gen/AMD64.rules
index d93811e..905bffe 100644
--- a/src/cmd/compile/internal/ssa/_gen/AMD64.rules
+++ b/src/cmd/compile/internal/ssa/_gen/AMD64.rules
@@ -234,12 +234,10 @@
(Load <t> ptr mem) && is64BitFloat(t) => (MOVSDload ptr mem)
// Lowering stores
-// These more-specific FP versions of Store pattern should come first.
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (MOVSDstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (MOVSSstore ptr val mem)
-
-(Store {t} ptr val mem) && t.Size() == 8 => (MOVQstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 => (MOVLstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (MOVSDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (MOVSSstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && !t.IsFloat() => (MOVQstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVLstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVWstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
diff --git a/src/cmd/compile/internal/ssa/_gen/ARM.rules b/src/cmd/compile/internal/ssa/_gen/ARM.rules
index 9ea9f96..0947b77 100644
--- a/src/cmd/compile/internal/ssa/_gen/ARM.rules
+++ b/src/cmd/compile/internal/ssa/_gen/ARM.rules
@@ -264,9 +264,9 @@
// stores
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVHstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && !is32BitFloat(val.Type) => (MOVWstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (MOVFstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (MOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVWstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (MOVFstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (MOVDstore ptr val mem)
// zero instructions
(Zero [0] _ mem) => mem
diff --git a/src/cmd/compile/internal/ssa/_gen/ARM64.rules b/src/cmd/compile/internal/ssa/_gen/ARM64.rules
index 3eb3c2e..70d286b 100644
--- a/src/cmd/compile/internal/ssa/_gen/ARM64.rules
+++ b/src/cmd/compile/internal/ssa/_gen/ARM64.rules
@@ -340,10 +340,10 @@
// stores
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVHstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && !is32BitFloat(val.Type) => (MOVWstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && !is64BitFloat(val.Type) => (MOVDstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (FMOVSstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (FMOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVWstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && !t.IsFloat() => (MOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (FMOVSstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (FMOVDstore ptr val mem)
// zeroing
(Zero [0] _ mem) => mem
diff --git a/src/cmd/compile/internal/ssa/_gen/LOONG64.rules b/src/cmd/compile/internal/ssa/_gen/LOONG64.rules
index e68baf0..d15bf1b 100644
--- a/src/cmd/compile/internal/ssa/_gen/LOONG64.rules
+++ b/src/cmd/compile/internal/ssa/_gen/LOONG64.rules
@@ -246,10 +246,10 @@
// stores
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVHstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && !is32BitFloat(val.Type) => (MOVWstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && !is64BitFloat(val.Type) => (MOVVstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (MOVFstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (MOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVWstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && !t.IsFloat() => (MOVVstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (MOVFstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (MOVDstore ptr val mem)
// zeroing
(Zero [0] _ mem) => mem
diff --git a/src/cmd/compile/internal/ssa/_gen/MIPS.rules b/src/cmd/compile/internal/ssa/_gen/MIPS.rules
index b74ab7b..d07f657 100644
--- a/src/cmd/compile/internal/ssa/_gen/MIPS.rules
+++ b/src/cmd/compile/internal/ssa/_gen/MIPS.rules
@@ -226,9 +226,9 @@
// stores
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVHstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && !is32BitFloat(val.Type) => (MOVWstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (MOVFstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (MOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVWstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (MOVFstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (MOVDstore ptr val mem)
// zero instructions
(Zero [0] _ mem) => mem
diff --git a/src/cmd/compile/internal/ssa/_gen/MIPS64.rules b/src/cmd/compile/internal/ssa/_gen/MIPS64.rules
index e5cfd90..d6cc63c 100644
--- a/src/cmd/compile/internal/ssa/_gen/MIPS64.rules
+++ b/src/cmd/compile/internal/ssa/_gen/MIPS64.rules
@@ -237,10 +237,10 @@
// stores
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVHstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && !is32BitFloat(val.Type) => (MOVWstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && !is64BitFloat(val.Type) => (MOVVstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (MOVFstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (MOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVWstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && !t.IsFloat() => (MOVVstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (MOVFstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (MOVDstore ptr val mem)
// zeroing
(Zero [0] _ mem) => mem
diff --git a/src/cmd/compile/internal/ssa/_gen/PPC64.rules b/src/cmd/compile/internal/ssa/_gen/PPC64.rules
index 1c8142c..9e0b44b 100644
--- a/src/cmd/compile/internal/ssa/_gen/PPC64.rules
+++ b/src/cmd/compile/internal/ssa/_gen/PPC64.rules
@@ -430,11 +430,10 @@
(Load <t> ptr mem) && is32BitFloat(t) => (FMOVSload ptr mem)
(Load <t> ptr mem) && is64BitFloat(t) => (FMOVDload ptr mem)
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (FMOVDstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && is32BitFloat(val.Type) => (FMOVDstore ptr val mem) // glitch from (Cvt32Fto64F x) => x -- type is wrong
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (FMOVSstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && !is64BitFloat(val.Type) => (MOVDstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitInt(val.Type) => (MOVWstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (FMOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (FMOVSstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && !t.IsFloat() => (MOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVWstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVHstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
diff --git a/src/cmd/compile/internal/ssa/_gen/RISCV64.rules b/src/cmd/compile/internal/ssa/_gen/RISCV64.rules
index 378b8c0..b6700cc 100644
--- a/src/cmd/compile/internal/ssa/_gen/RISCV64.rules
+++ b/src/cmd/compile/internal/ssa/_gen/RISCV64.rules
@@ -296,10 +296,10 @@
// Stores
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVHstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && !is32BitFloat(val.Type) => (MOVWstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && !is64BitFloat(val.Type) => (MOVDstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (FMOVWstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (FMOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVWstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && !t.IsFloat() => (MOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (FMOVWstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (FMOVDstore ptr val mem)
// We need to fold MOVaddr into the LD/MOVDstore ops so that the live variable analysis
// knows what variables are being read/written by the ops.
diff --git a/src/cmd/compile/internal/ssa/_gen/S390X.rules b/src/cmd/compile/internal/ssa/_gen/S390X.rules
index 4502a57..c85c559 100644
--- a/src/cmd/compile/internal/ssa/_gen/S390X.rules
+++ b/src/cmd/compile/internal/ssa/_gen/S390X.rules
@@ -346,12 +346,10 @@
(Load <t> ptr mem) && is64BitFloat(t) => (FMOVDload ptr mem)
// Lowering stores
-// These more-specific FP versions of Store pattern should come first.
-(Store {t} ptr val mem) && t.Size() == 8 && is64BitFloat(val.Type) => (FMOVDstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 && is32BitFloat(val.Type) => (FMOVSstore ptr val mem)
-
-(Store {t} ptr val mem) && t.Size() == 8 => (MOVDstore ptr val mem)
-(Store {t} ptr val mem) && t.Size() == 4 => (MOVWstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && t.IsFloat() => (FMOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && t.IsFloat() => (FMOVSstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 8 && !t.IsFloat() => (MOVDstore ptr val mem)
+(Store {t} ptr val mem) && t.Size() == 4 && !t.IsFloat() => (MOVWstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 2 => (MOVHstore ptr val mem)
(Store {t} ptr val mem) && t.Size() == 1 => (MOVBstore ptr val mem)
diff --git a/src/cmd/compile/internal/ssa/rewrite386.go b/src/cmd/compile/internal/ssa/rewrite386.go
index fe5bbe5..550e7d5 100644
--- a/src/cmd/compile/internal/ssa/rewrite386.go
+++ b/src/cmd/compile/internal/ssa/rewrite386.go
@@ -11224,14 +11224,14 @@
v_1 := v.Args[1]
v_0 := v.Args[0]
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (MOVSDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(Op386MOVSDstore)
@@ -11239,14 +11239,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (MOVSSstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(Op386MOVSSstore)
@@ -11254,14 +11254,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVLstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(Op386MOVLstore)
diff --git a/src/cmd/compile/internal/ssa/rewriteAMD64.go b/src/cmd/compile/internal/ssa/rewriteAMD64.go
index 86b69b5..2cc8040 100644
--- a/src/cmd/compile/internal/ssa/rewriteAMD64.go
+++ b/src/cmd/compile/internal/ssa/rewriteAMD64.go
@@ -33049,14 +33049,14 @@
v_1 := v.Args[1]
v_0 := v.Args[0]
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (MOVSDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(OpAMD64MOVSDstore)
@@ -33064,14 +33064,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (MOVSSstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(OpAMD64MOVSSstore)
@@ -33079,14 +33079,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8
+ // cond: t.Size() == 8 && !t.IsFloat()
// result: (MOVQstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8) {
+ if !(t.Size() == 8 && !t.IsFloat()) {
break
}
v.reset(OpAMD64MOVQstore)
@@ -33094,14 +33094,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVLstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(OpAMD64MOVLstore)
diff --git a/src/cmd/compile/internal/ssa/rewriteARM.go b/src/cmd/compile/internal/ssa/rewriteARM.go
index 896ea50..b495a9c 100644
--- a/src/cmd/compile/internal/ssa/rewriteARM.go
+++ b/src/cmd/compile/internal/ssa/rewriteARM.go
@@ -15912,14 +15912,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && !is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVWstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && !is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(OpARMMOVWstore)
@@ -15927,14 +15927,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (MOVFstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(OpARMMOVFstore)
@@ -15942,14 +15942,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (MOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(OpARMMOVDstore)
diff --git a/src/cmd/compile/internal/ssa/rewriteARM64.go b/src/cmd/compile/internal/ssa/rewriteARM64.go
index b7466f9..f6e5796 100644
--- a/src/cmd/compile/internal/ssa/rewriteARM64.go
+++ b/src/cmd/compile/internal/ssa/rewriteARM64.go
@@ -28941,14 +28941,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && !is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVWstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && !is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(OpARM64MOVWstore)
@@ -28956,14 +28956,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && !is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && !t.IsFloat()
// result: (MOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && !is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && !t.IsFloat()) {
break
}
v.reset(OpARM64MOVDstore)
@@ -28971,14 +28971,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (FMOVSstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(OpARM64FMOVSstore)
@@ -28986,14 +28986,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (FMOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(OpARM64FMOVDstore)
diff --git a/src/cmd/compile/internal/ssa/rewriteLOONG64.go b/src/cmd/compile/internal/ssa/rewriteLOONG64.go
index 8eacc1f..1581e82 100644
--- a/src/cmd/compile/internal/ssa/rewriteLOONG64.go
+++ b/src/cmd/compile/internal/ssa/rewriteLOONG64.go
@@ -7225,14 +7225,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && !is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVWstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && !is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(OpLOONG64MOVWstore)
@@ -7240,14 +7240,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && !is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && !t.IsFloat()
// result: (MOVVstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && !is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && !t.IsFloat()) {
break
}
v.reset(OpLOONG64MOVVstore)
@@ -7255,14 +7255,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (MOVFstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(OpLOONG64MOVFstore)
@@ -7270,14 +7270,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (MOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(OpLOONG64MOVDstore)
diff --git a/src/cmd/compile/internal/ssa/rewriteMIPS.go b/src/cmd/compile/internal/ssa/rewriteMIPS.go
index 4d56908..85be033 100644
--- a/src/cmd/compile/internal/ssa/rewriteMIPS.go
+++ b/src/cmd/compile/internal/ssa/rewriteMIPS.go
@@ -6785,14 +6785,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && !is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVWstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && !is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(OpMIPSMOVWstore)
@@ -6800,14 +6800,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (MOVFstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(OpMIPSMOVFstore)
@@ -6815,14 +6815,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (MOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(OpMIPSMOVDstore)
diff --git a/src/cmd/compile/internal/ssa/rewriteMIPS64.go b/src/cmd/compile/internal/ssa/rewriteMIPS64.go
index 8b01407..af4ab1e 100644
--- a/src/cmd/compile/internal/ssa/rewriteMIPS64.go
+++ b/src/cmd/compile/internal/ssa/rewriteMIPS64.go
@@ -7337,14 +7337,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && !is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVWstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && !is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(OpMIPS64MOVWstore)
@@ -7352,14 +7352,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && !is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && !t.IsFloat()
// result: (MOVVstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && !is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && !t.IsFloat()) {
break
}
v.reset(OpMIPS64MOVVstore)
@@ -7367,14 +7367,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (MOVFstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(OpMIPS64MOVFstore)
@@ -7382,14 +7382,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (MOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(OpMIPS64MOVDstore)
diff --git a/src/cmd/compile/internal/ssa/rewritePPC64.go b/src/cmd/compile/internal/ssa/rewritePPC64.go
index 50c10fd..e4ef393 100644
--- a/src/cmd/compile/internal/ssa/rewritePPC64.go
+++ b/src/cmd/compile/internal/ssa/rewritePPC64.go
@@ -16056,14 +16056,14 @@
v_1 := v.Args[1]
v_0 := v.Args[0]
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (FMOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(OpPPC64FMOVDstore)
@@ -16071,29 +16071,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is32BitFloat(val.Type)
- // result: (FMOVDstore ptr val mem)
- for {
- t := auxToType(v.Aux)
- ptr := v_0
- val := v_1
- mem := v_2
- if !(t.Size() == 8 && is32BitFloat(val.Type)) {
- break
- }
- v.reset(OpPPC64FMOVDstore)
- v.AddArg3(ptr, val, mem)
- return true
- }
- // match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (FMOVSstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(OpPPC64FMOVSstore)
@@ -16101,14 +16086,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && !is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && !t.IsFloat()
// result: (MOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && !is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && !t.IsFloat()) {
break
}
v.reset(OpPPC64MOVDstore)
@@ -16116,14 +16101,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitInt(val.Type)
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVWstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitInt(val.Type)) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(OpPPC64MOVWstore)
diff --git a/src/cmd/compile/internal/ssa/rewriteRISCV64.go b/src/cmd/compile/internal/ssa/rewriteRISCV64.go
index 6885127..021db10 100644
--- a/src/cmd/compile/internal/ssa/rewriteRISCV64.go
+++ b/src/cmd/compile/internal/ssa/rewriteRISCV64.go
@@ -7862,14 +7862,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && !is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVWstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && !is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(OpRISCV64MOVWstore)
@@ -7877,14 +7877,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && !is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && !t.IsFloat()
// result: (MOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && !is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && !t.IsFloat()) {
break
}
v.reset(OpRISCV64MOVDstore)
@@ -7892,14 +7892,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (FMOVWstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(OpRISCV64FMOVWstore)
@@ -7907,14 +7907,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (FMOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(OpRISCV64FMOVDstore)
diff --git a/src/cmd/compile/internal/ssa/rewriteS390X.go b/src/cmd/compile/internal/ssa/rewriteS390X.go
index e8cc88d..bd920ef 100644
--- a/src/cmd/compile/internal/ssa/rewriteS390X.go
+++ b/src/cmd/compile/internal/ssa/rewriteS390X.go
@@ -15646,14 +15646,14 @@
v_1 := v.Args[1]
v_0 := v.Args[0]
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8 && is64BitFloat(val.Type)
+ // cond: t.Size() == 8 && t.IsFloat()
// result: (FMOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8 && is64BitFloat(val.Type)) {
+ if !(t.Size() == 8 && t.IsFloat()) {
break
}
v.reset(OpS390XFMOVDstore)
@@ -15661,14 +15661,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4 && is32BitFloat(val.Type)
+ // cond: t.Size() == 4 && t.IsFloat()
// result: (FMOVSstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4 && is32BitFloat(val.Type)) {
+ if !(t.Size() == 4 && t.IsFloat()) {
break
}
v.reset(OpS390XFMOVSstore)
@@ -15676,14 +15676,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 8
+ // cond: t.Size() == 8 && !t.IsFloat()
// result: (MOVDstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 8) {
+ if !(t.Size() == 8 && !t.IsFloat()) {
break
}
v.reset(OpS390XMOVDstore)
@@ -15691,14 +15691,14 @@
return true
}
// match: (Store {t} ptr val mem)
- // cond: t.Size() == 4
+ // cond: t.Size() == 4 && !t.IsFloat()
// result: (MOVWstore ptr val mem)
for {
t := auxToType(v.Aux)
ptr := v_0
val := v_1
mem := v_2
- if !(t.Size() == 4) {
+ if !(t.Size() == 4 && !t.IsFloat()) {
break
}
v.reset(OpS390XMOVWstore)
