)]}' { "commit": "4fc9d3bc58413861f2012c24065ce3f7ed9df4db", "tree": "512ac5e06499243fc8a8597c88e54ef037608c4a", "parents": [ "92e78f7e8d1bc92cb91d18e912ee20076a4747aa" ], "author": { "name": "Jay Conrod", "email": "jayconrod@google.com", "time": "Mon Mar 18 18:35:44 2019 -0400" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Fri Apr 05 19:08:44 2019 +0000" }, "message": "[release-branch.go1.12] cmd/go: avoid link error when -coverpkg covers main packages (more)\n\nThis fixes two problems missed in CL 164877.\n\nFirst, p.Internal.BuildInfo is now part of the cache key. This is\nimportant since p.Internal.BuildInfo causes the build action to\nsynthesize a new source file, which affects the output.\n\nSecond, recompileForTest is always called for test\npackages. Previously, it was only called when there were internal test\nsources, so the fix in CL 164877 did not apply to packages that only\nhad external tests.\n\nFixes #30937\n\nChange-Id: Iac2d7e8914f0313f9ab4222299a866f67889eb2e\nReviewed-on: https://go-review.googlesource.com/c/go/+/168200\nRun-TryBot: Jay Conrod \u003cjayconrod@google.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\n(cherry picked from commit d34548e0b6acc14a99bc6ffc225eedbb56e03d60)\nReviewed-on: https://go-review.googlesource.com/c/go/+/168717\nRun-TryBot: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "6293aea3c36dbe23393517581fa40f414727e145", "old_mode": 33188, "old_path": "src/cmd/go/internal/load/test.go", "new_id": "48d03d8fce404bd37890c0d24a86199865d3fa2d", "new_mode": 33188, "new_path": "src/cmd/go/internal/load/test.go" }, { "type": "modify", "old_id": "bbcbdd75686a300d7ecc15f358127a2493eda987", "old_mode": 33188, "old_path": "src/cmd/go/internal/work/exec.go", "new_id": "0ab7976c5638cee1ebfad1325cd08bee541e7ddd", "new_mode": 33188, "new_path": "src/cmd/go/internal/work/exec.go" }, { "type": "modify", "old_id": "8ee4848d0a247040b4bd5b842ffcc42cbf50095e", "old_mode": 33188, "old_path": "src/cmd/go/testdata/script/cover_pkgall_multiple_mains.txt", "new_id": "ab7cd66949db0fbb60ddd3084c6d11e8082d2593", "new_mode": 33188, "new_path": "src/cmd/go/testdata/script/cover_pkgall_multiple_mains.txt" } ] }