tree e994fd4340523b1ba222cd789dd9d1ee01371c33
parent 070e2dda0252138ebe319a4f8839d71cbf57cd2a
author Bryan C. Mills <bcmills@google.com> 1561497201 -0400
committer Bryan C. Mills <bcmills@google.com> 1561576469 +0000

cmd/go/internal/modfetch: halt proxy fallback if the proxy returns a non-404/410 response for @latest

The @latest proxy endpoint is optional. If a proxy returns a 404 for
it, and returns an @v/list with no matching versions, then we should
allow module lookup to try other module paths. However, if the proxy
returns some other error (say, a 403 or 505), then the result of the
lookup is ambiguous, and we should report the actual error rather than
"no matching versions for query".

(This fix was prompted by discussion with Dmitri on CL 183619.)

Updates #32715
Updates #26334

Change-Id: I6d510a5ac24d48d9bc5037c3c747ac50695c663f
Reviewed-on: https://go-review.googlesource.com/c/go/+/183845
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>