codereview: make sure each mail has a reviewer
R=r
CC=golang-dev
https://golang.org/cl/196050
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 9f7470be..a33ea38 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -960,8 +960,16 @@
if err != "":
return err
cl.Upload(ui, repo, gofmt_just_warn=True)
- if not cl.reviewer and not cl.cc:
- return "no reviewers listed in CL"
+ if not cl.reviewer:
+ # If no reviewer is listed, assign the review to defaultcc.
+ # This makes sure that it appears in the
+ # codereview.appspot.com/user/defaultcc
+ # page, so that it doesn't get dropped on the floor.
+ if not defaultcc:
+ return "no reviewers listed in CL"
+ cl.cc = Sub(cl.cc, defaultcc)
+ cl.reviewer = defaultcc
+ cl.Flush(ui, repo)
cl.Mail(ui, repo)
def nocommit(ui, repo, *pats, **opts):
