)]}' { "commit": "4220d670844e15f78041a9fa7dea1c2a89a9b139", "tree": "63ef87496e6de1c0f158785c4d07cee13f503d85", "parents": [ "c0602603b20186228b4f89f265cb3f7665e06768" ], "author": { "name": "David Chase", "email": "drchase@google.com", "time": "Wed Aug 05 10:26:57 2020 -0400" }, "committer": { "name": "David Chase", "email": "drchase@google.com", "time": "Mon Aug 24 02:38:18 2020 +0000" }, "message": "cmd/compile: make GOSSAHASH package-sensitive, also append to log files\n\nTurns out if your failure is in a function with a name like \"Reset()\"\nthere will be a lot of hits on the same hashcode. Adding package sensitivity\nsolves this problem.\n\nIn additionm, it turned out that in the case that a logfile was specified\nfor the GOSSAHASH logging, that it was opened in create mode, which meant\nthat multiple compiler invocations would reset the file to zero length.\nOpening in append mode works better; the automated harness\n(github.com/dr2chase/gossahash) takes care of truncating the file before use.\n\nChange-Id: I5601bc280faa94cbd507d302448831849db6c842\nReviewed-on: https://go-review.googlesource.com/c/go/+/246937\nRun-TryBot: David Chase \u003cdrchase@google.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "956569b86f379d9af03ff8549250a1f36877b218", "old_mode": 33188, "old_path": "src/cmd/compile/internal/gc/ssa.go", "new_id": "c8fb013ad0a021b3dec61d8ff2d5156a55920f6d", "new_mode": 33188, "new_path": "src/cmd/compile/internal/gc/ssa.go" }, { "type": "modify", "old_id": "fdff3bbdeb2508ab5090f2e679a3c7ee98ea6d92", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/config.go", "new_id": "4b2f06def11ff689186f3af5af788cd7269bfe7f", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/config.go" }, { "type": "modify", "old_id": "a94cce48a41408133d97165cb6b2bd336c1be59e", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/export_test.go", "new_id": "51665c60e2783b2212ab49c031ccf57a1f3e69ab", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/export_test.go" }, { "type": "modify", "old_id": "9e40b6214c140cfa8a25985753b2c918918aa433", "old_mode": 33188, "old_path": "src/cmd/compile/internal/ssa/func.go", "new_id": "6718b778e1d73549764c211d235eb0cbb254120b", "new_mode": 33188, "new_path": "src/cmd/compile/internal/ssa/func.go" } ] }