commit 37373592afe200a13d6ecf02b73a97e51beef9e1
author Eddie Scholtz <escholtz@google.com> Tue Aug 27 13:33:45 2019 -0600
committer Daniel Martí <mvdan@mvdan.cc> Wed Aug 28 10:21:40 2019 +0000
tree 7154342c85d542e205c073f9422ea0e26ac731b8
parent 5ff12f6269c5851cfb762357d12e9ed1e3d582e9

encoding/xml: rename fInnerXml to fInnerXML

Per the code review guidelines: "Words in names that are
initialisms or acronyms have a consistent case."

Change-Id: I347b02d2f48455f2cbbc040191ba197e3e8f23fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/191970
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/encoding/xml/marshal.go

diff --git a/src/encoding/xml/marshal.go b/src/encoding/xml/marshal.go
index add5ece..e325f31 100644
--- a/src/encoding/xml/marshal.go
+++ b/src/encoding/xml/marshal.go
@@ -914,7 +914,7 @@
 			p.WriteString("-->")
 			continue
 
-		case fInnerXml:
+		case fInnerXML:
 			vf = indirect(vf)
 			iface := vf.Interface()
 			switch raw := iface.(type) {

src/encoding/xml/read.go

diff --git a/src/encoding/xml/read.go b/src/encoding/xml/read.go
index 12102bc..10a60ee 100644
--- a/src/encoding/xml/read.go
+++ b/src/encoding/xml/read.go
@@ -491,7 +491,7 @@
 					saveAny = finfo.value(sv)
 				}
 
-			case fInnerXml:
+			case fInnerXML:
 				if !saveXML.IsValid() {
 					saveXML = finfo.value(sv)
 					if d.saved == nil {

src/encoding/xml/typeinfo.go

diff --git a/src/encoding/xml/typeinfo.go b/src/encoding/xml/typeinfo.go
index 48de3d7..639952c 100644
--- a/src/encoding/xml/typeinfo.go
+++ b/src/encoding/xml/typeinfo.go
@@ -33,13 +33,13 @@
 	fAttr
 	fCDATA
 	fCharData
-	fInnerXml
+	fInnerXML
 	fComment
 	fAny
 
 	fOmitEmpty
 
-	fMode = fElement | fAttr | fCDATA | fCharData | fInnerXml | fComment | fAny
+	fMode = fElement | fAttr | fCDATA | fCharData | fInnerXML | fComment | fAny
 
 	xmlName = "XMLName"
 )
@@ -134,7 +134,7 @@
 			case "chardata":
 				finfo.flags |= fCharData
 			case "innerxml":
-				finfo.flags |= fInnerXml
+				finfo.flags |= fInnerXML
 			case "comment":
 				finfo.flags |= fComment
 			case "any":
@@ -149,7 +149,7 @@
 		switch mode := finfo.flags & fMode; mode {
 		case 0:
 			finfo.flags |= fElement
-		case fAttr, fCDATA, fCharData, fInnerXml, fComment, fAny, fAny | fAttr:
+		case fAttr, fCDATA, fCharData, fInnerXML, fComment, fAny, fAny | fAttr:
 			if f.Name == xmlName || tag != "" && mode != fAttr {
 				valid = false
 			}