cmd/go/testdata/script: remove net condition from always skipped tests mod_replace_gopkgin is unconditionally skipped, and there is an unconditional skip in mod_replace_gopkgin. Remove the net condition checks from these tests. We want to add an allowlist for the tests that use net and make it as small as possible. Since these tests shouldn't access the network once they're fixed and reenabled, just remove the condition. For #80243 Change-Id: I690e2668281901103b55f6d66eaa81816a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/795920 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Michael Matloob <matloob@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
diff --git a/src/cmd/go/testdata/script/mod_gopkg_unstable.txt b/src/cmd/go/testdata/script/mod_gopkg_unstable.txt index 856f493..34e6de3 100644 --- a/src/cmd/go/testdata/script/mod_gopkg_unstable.txt +++ b/src/cmd/go/testdata/script/mod_gopkg_unstable.txt
@@ -7,10 +7,9 @@ cp go.mod.empty go.mod go list -[!net:gopkg.in] skip +skip # TODO(#54503): redirect gopkg.in requests to a local server and re-enable. [!git] skip -skip # TODO(#54503): redirect gopkg.in requests to a local server and re-enable. env GOPROXY=direct env GOSUMDB=off
diff --git a/src/cmd/go/testdata/script/mod_replace_gopkgin.txt b/src/cmd/go/testdata/script/mod_replace_gopkgin.txt index 91008f9..8d7de07 100644 --- a/src/cmd/go/testdata/script/mod_replace_gopkgin.txt +++ b/src/cmd/go/testdata/script/mod_replace_gopkgin.txt
@@ -5,9 +5,7 @@ # gopkg.in path. skip 'skipping test that depends on an unreliable third-party server; see https://go.dev/issue/54503' - # TODO(#54043): Make this test hermetic and re-enable it. - -[!net:gopkg.in] skip +# TODO(#54503): Make this work without needing the external network, and then re-enable. [!git] skip env GO111MODULE=on