commit 323212b9e6edd55e99d973d00d2132995762c858
author Dmitri Shuralyov <dmitshur@golang.org> Sun Jun 09 12:04:23 2019 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> Sun Jun 09 16:23:11 2019 +0000
tree a6ef11029f8da7cd210ab42de5816c6d8554bbab
parent 13f179b9c8c3b9d9066e71d0a69cff8c0876098b

cmd/go: fix syntax mistake in a testscript file, take 2

This is a followup to CL 181278 and CL 181177.

According to cmd/go/testdata/script/README:

	Each line is parsed into a sequence of space-separated command words,
	with environment variable expansion and # marking an end-of-line comment.
	Adding single quotes around text keeps spaces in that text from being treated
	as word separators and also disables environment variable expansion.

We want $HOME to be expanded, so leave it out of the single-quoted
block of text.

I tested this change on macOS, and it makes TestScript/env_write pass.

Fixes #32503

Change-Id: I13621aec82263e5cb6978c13a1ad71d2210a0e42
Reviewed-on: https://go-review.googlesource.com/c/go/+/181418
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/testdata/script/env_write.txt

diff --git a/src/cmd/go/testdata/script/env_write.txt b/src/cmd/go/testdata/script/env_write.txt
index ea15087..695cc83 100644
--- a/src/cmd/go/testdata/script/env_write.txt
+++ b/src/cmd/go/testdata/script/env_write.txt
@@ -5,7 +5,7 @@
 env home=$HOME/plan9home
 go env GOENV
 [aix] stdout $HOME/.config/go/env
-[darwin] stdout '$HOME/Library/Application Support/go/env'
+[darwin] stdout $HOME'/Library/Application Support/go/env'
 [freebsd] stdout $HOME/.config/go/env
 [linux] stdout $HOME/.config/go/env
 [netbsd] stdout $HOME/.config/go/env