tree 109d39e7f1b20ecbc336ad96804deca6356b1e1b
parent f6f6621312263e1e3ea2928bdccc967f0f977865
author Dan Scales <danscales@google.com> 1632177249 -0700
committer Dan Scales <danscales@google.com> 1632256771 +0000

cmd/compile: don't create or instantiate methods on shape types

We should never use or need methods on non-interface shape types. We do
have corresponding functions instantiated with the appropriate
shape types that take the dictionary and the shape-based receiver as the
first two arguments. Each such function has the same name as what the
corresponding method would be, so it's best not to create the methods
(which would create confusion for import/export). This fixes issue
48414, which happened because of the confusion between these two
functions/methods.

Fixes #48414

Change-Id: I401fbdad791bdb5792617449cad68aa8df1d9911
Reviewed-on: https://go-review.googlesource.com/c/go/+/351114
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>