| commit | 48cf96c256ff1ec68fd9f9daa59900352d916730 | [log] [tgz] |
|---|---|---|
| author | Dan Scales <danscales@google.com> | Mon Sep 20 15:34:09 2021 -0700 |
| committer | Dan Scales <danscales@google.com> | Tue Sep 21 20:39:31 2021 +0000 |
| tree | 109d39e7f1b20ecbc336ad96804deca6356b1e1b | |
| parent | f6f6621312263e1e3ea2928bdccc967f0f977865 [diff] |
cmd/compile: don't create or instantiate methods on shape types We should never use or need methods on non-interface shape types. We do have corresponding functions instantiated with the appropriate shape types that take the dictionary and the shape-based receiver as the first two arguments. Each such function has the same name as what the corresponding method would be, so it's best not to create the methods (which would create confusion for import/export). This fixes issue 48414, which happened because of the confusion between these two functions/methods. Fixes #48414 Change-Id: I401fbdad791bdb5792617449cad68aa8df1d9911 Reviewed-on: https://go-review.googlesource.com/c/go/+/351114 Trust: Dan Scales <danscales@google.com> Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.