codereview: fix hgpatch on windows
R=rsc
CC=golang-dev
https://golang.org/cl/3989059
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index cd0c7a8..94270f8 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1142,12 +1142,11 @@
if err != "":
return err
try:
- cmd = subprocess.Popen(argv, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=None, close_fds=True)
+ cmd = subprocess.Popen(argv, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=None, close_fds=sys.platform != "win32")
except:
return "hgpatch: " + ExceptionDetail()
- if os.fork() == 0:
- cmd.stdin.write(patch)
- os._exit(0)
+
+ cmd.stdin.write(patch)
cmd.stdin.close()
out = cmd.stdout.read()
if cmd.wait() != 0 and not opts["ignore_hgpatch_failure"]:
