)]}'
{
  "commit": "0f8dffd0aa71ed996d32e77701ac5ec0bc7cde01",
  "tree": "9840e8c7e2abac7674a9dfaa6b0c73655124f0fa",
  "parents": [
    "5639fcae7fee2cf04c1b87e9a81155ee3bb6ed71"
  ],
  "author": {
    "name": "Cuong Manh Le",
    "email": "cuong.manhle.vn@gmail.com",
    "time": "Sat May 08 00:45:06 2021 +0700"
  },
  "committer": {
    "name": "Cuong Manh Le",
    "email": "cuong.manhle.vn@gmail.com",
    "time": "Tue Aug 09 11:28:56 2022 +0000"
  },
  "message": "all: use \":\" for compiler generated symbols\n\nAs it can\u0027t appear in user package paths.\n\nThere is a hack for handling \"go:buildid\" and \"type:*\" on windows/386.\n\nPreviously, windows/386 requires underscore prefix on external symbols,\nbut that\u0027s only applied for SHOSTOBJ/SUNDEFEXT or cgo export symbols.\n\"go.buildid\" is STEXT, \"type.*\" is STYPE, thus they are not prefixed\nwith underscore.\n\nIn external linking mode, the external linker can\u0027t resolve them as\nexternal symbols. But we are lucky that they have \".\" in their name,\nso the external linker see them as Forwarder RVA exports. See:\n\n - https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#export-address-table\n - https://sourceware.org/git/?p\u003dbinutils-gdb.git;a\u003dblob;f\u003dld/pe-dll.c;h\u003de7b82ba6ffadf74dc1b9ee71dc13d48336941e51;hb\u003dHEAD#l972)\n\nThis CL changes \".\" to \":\" in symbols name, so theses symbols can not be\nfound by external linker anymore. So a hacky way is adding the\nunderscore prefix for these 2 symbols. I don\u0027t have enough knowledge to\nverify whether adding the underscore for all STEXT/STYPE symbols are\nfine, even if it could be, that would be done in future CL.\n\nFixes #37762\n\nChange-Id: I92eaaf24c0820926a36e0530fdb07b07af1fcc35\nReviewed-on: https://go-review.googlesource.com/c/go/+/317917\nReviewed-by: Than McIntosh \u003cthanm@google.com\u003e\nRun-TryBot: Cuong Manh Le \u003ccuong.manhle.vn@gmail.com\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "756c4baa6b3a7ffdab14e36f5399b972c9fe477a",
      "old_mode": 33188,
      "old_path": "misc/cgo/testshared/shared_test.go",
      "new_id": "634d7556a8f9d8073adcf6fd23f1677616b401bd",
      "new_mode": 33188,
      "new_path": "misc/cgo/testshared/shared_test.go"
    },
    {
      "type": "modify",
      "old_id": "49fe4352b2f65793e83a48372392c7d6649b792a",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/base/link.go",
      "new_id": "d8aa5a7dccd209c4e17f758442a1427e1dd3d8b6",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/base/link.go"
    },
    {
      "type": "modify",
      "old_id": "4bbc04826a8dc0414629a3dfcb5f817a3efb3828",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/dwarfgen/dwarf.go",
      "new_id": "bdaa04339691c2555836443c69ca34bb62eccc82",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/dwarfgen/dwarf.go"
    },
    {
      "type": "modify",
      "old_id": "a5a2d56c466e94ab3efbd310e55e426d258ac8c7",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/gc/main.go",
      "new_id": "c9493bf5934e1dc45175c54f5bf25792c055135b",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/gc/main.go"
    },
    {
      "type": "modify",
      "old_id": "5008aa212aa72782ae1560723226463c168f9618",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/gc/obj.go",
      "new_id": "715b8ee2637e002ed58d6ef5caae0e62e939d827",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/gc/obj.go"
    },
    {
      "type": "modify",
      "old_id": "0058a98824e102ffc67a3bf70cc29d868b611c74",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/ir/expr.go",
      "new_id": "83105de253d650e462cfd24e5b9644bfd9f9d0c9",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/ir/expr.go"
    },
    {
      "type": "modify",
      "old_id": "49b8fd142a025eb59d8e644b985eb33b11aa01d7",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/noder/import.go",
      "new_id": "8b017ecfd59b2931aacff1abce3e782b387f5760",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/noder/import.go"
    },
    {
      "type": "modify",
      "old_id": "c4097947bf1e7199233270f0c68b99422a6695f5",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/ppc64/ssa.go",
      "new_id": "af75b04c6bcf427f65251ad1b511447c6b5b6373",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/ppc64/ssa.go"
    },
    {
      "type": "modify",
      "old_id": "8fb2d50c40d020230202de5dfefa7e20826f3f50",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/reflectdata/reflect.go",
      "new_id": "5833c71f4c5347940ef086f5bfdbbb6d221881f5",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/reflectdata/reflect.go"
    },
    {
      "type": "modify",
      "old_id": "621da9cbf617425ad6a1a82d8a758cc64bda6abf",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/staticdata/data.go",
      "new_id": "da0db5a573d07af9e668bfdf5e901794581b9b60",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/staticdata/data.go"
    },
    {
      "type": "modify",
      "old_id": "8ba57371e61b3ac3f6a875521c58ff233e27342b",
      "old_mode": 33188,
      "old_path": "src/cmd/internal/dwarf/dwarf.go",
      "new_id": "4821efa963edcd59a414cb29a57f291290050fe5",
      "new_mode": 33188,
      "new_path": "src/cmd/internal/dwarf/dwarf.go"
    },
    {
      "type": "modify",
      "old_id": "2d13222984dc40ed4286fba844f9d8d8ae5bb4fe",
      "old_mode": 33188,
      "old_path": "src/cmd/internal/goobj/builtinlist.go",
      "new_id": "ae2e6cc0041689802fda81c8d170929adb0a2611",
      "new_mode": 33188,
      "new_path": "src/cmd/internal/goobj/builtinlist.go"
    },
    {
      "type": "modify",
      "old_id": "c9995fcedef8eee70bc68b8477c13fc4697dc313",
      "old_mode": 33188,
      "old_path": "src/cmd/internal/goobj/mkbuiltin.go",
      "new_id": "d9db63ad4450110999702db856d7bd48a02937c9",
      "new_mode": 33188,
      "new_path": "src/cmd/internal/goobj/mkbuiltin.go"
    },
    {
      "type": "modify",
      "old_id": "89339b0147c147e70a3e1590c80cd5395046c564",
      "old_mode": 33188,
      "old_path": "src/cmd/internal/obj/objfile.go",
      "new_id": "ec699a79516e0f4cfe1c1514e21f3d3a4ca0220f",
      "new_mode": 33188,
      "new_path": "src/cmd/internal/obj/objfile.go"
    },
    {
      "type": "modify",
      "old_id": "cb2afeaa9ac5c8429c93400d85bb086ed361b695",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/data.go",
      "new_id": "c2668b29a44f882ba87b0db1a80f467ec738d818",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/data.go"
    },
    {
      "type": "modify",
      "old_id": "48f447b1fae587f7486f1e4d6b474875561885e6",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/deadcode.go",
      "new_id": "0738a51deb02154d53666cb9868a45e217db47ef",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/deadcode.go"
    },
    {
      "type": "modify",
      "old_id": "6e128432dcb932a62fd46b04b5e46429d69dd8d9",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/deadcode_test.go",
      "new_id": "ed37a088128d40048304e5c36d57c0706c5088d8",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/deadcode_test.go"
    },
    {
      "type": "modify",
      "old_id": "c42511ea3f04c1e2698b27851a49a97daf18e355",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/dwarf.go",
      "new_id": "75fabb4bd8c5101bdd626d0bdfca24488e914a08",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/dwarf.go"
    },
    {
      "type": "modify",
      "old_id": "040978e6fccf7a9697abf7442bb1034661cc982b",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/elf.go",
      "new_id": "dd5844bd10ee0aa133ea70a4611bf185f8973264",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/elf.go"
    },
    {
      "type": "modify",
      "old_id": "1affe24916593e51be3679dec9a43a5c72ff9628",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/go.go",
      "new_id": "171f3cef114362b390caf9b42594f34acc912f8b",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/go.go"
    },
    {
      "type": "modify",
      "old_id": "aaad152e6ff682ac5d37d5f24985c0fe4335d611",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/ld.go",
      "new_id": "709a6d0be6ef998e96362d05cd03771158d488aa",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/ld.go"
    },
    {
      "type": "modify",
      "old_id": "c265d73893b96de0192393d33d57edddd7cbaf04",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/lib.go",
      "new_id": "14dc5433fb521829ed357c141acf89557b4d09ee",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/lib.go"
    },
    {
      "type": "modify",
      "old_id": "e7fd1cde9748b2bbfaa8503d9a3532b40fee9c07",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/macho.go",
      "new_id": "11cbf814861b5d093ce8517f184666a4447063b5",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/macho.go"
    },
    {
      "type": "modify",
      "old_id": "7a7a4833aa446c6a047d85b711209d2649821143",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/pcln.go",
      "new_id": "45a4e07fb74a1c57c5aaed50acabddf8355da503",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/pcln.go"
    },
    {
      "type": "modify",
      "old_id": "6d1cd7283ac2a20726981a7202e606d5a27bf569",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/pe.go",
      "new_id": "0e291311a0afa08c5e7d3bdd6961efad74b94fee",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/pe.go"
    },
    {
      "type": "modify",
      "old_id": "ee963bc366bdac2cdbc7e545b3dd0c027177f897",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/symtab.go",
      "new_id": "02b384ba9dfeffa139f791e2a3eba31000a10dee",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/symtab.go"
    },
    {
      "type": "modify",
      "old_id": "259db131af8698d8815764a0900e06391d1ddd2d",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/ld/xcoff.go",
      "new_id": "3fac071a0461f0bc0e1e3eb29e9b633a1c91d84c",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/ld/xcoff.go"
    },
    {
      "type": "modify",
      "old_id": "664f345ead3424aee21c237860dea1b03ed56c61",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/loader/loader.go",
      "new_id": "52c7d72835c0fd9129f8e8f5c9eb425509f48675",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/loader/loader.go"
    },
    {
      "type": "modify",
      "old_id": "b22e2136bbfa39410122adfc01d2b1a433bb98e3",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/loader/loader_test.go",
      "new_id": "7d1031e9dc6187c912aab71eb64aab9ebd1f0c18",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/loader/loader_test.go"
    },
    {
      "type": "modify",
      "old_id": "01c500ed70e6dc3e0baed4176e4dab2073865ede",
      "old_mode": 33188,
      "old_path": "src/cmd/link/internal/wasm/asm.go",
      "new_id": "45cb209e974482cd04f9e46d9725bb4a508f8b96",
      "new_mode": 33188,
      "new_path": "src/cmd/link/internal/wasm/asm.go"
    },
    {
      "type": "modify",
      "old_id": "8c392ff7c48102647eef9fdca371018fa2b09c79",
      "old_mode": 33188,
      "old_path": "src/crypto/tls/link_test.go",
      "new_id": "454d370c8852bb875504dd68385e645205e6eae0",
      "new_mode": 33188,
      "new_path": "src/crypto/tls/link_test.go"
    },
    {
      "type": "modify",
      "old_id": "2ceea3d46f3fa6ac2fb19e7baf0e254a19e91d52",
      "old_mode": 33188,
      "old_path": "src/debug/gosym/pclntab.go",
      "new_id": "1aed5ed7e7ed6e5d089b3ee4cd24504a778b4e55",
      "new_mode": 33188,
      "new_path": "src/debug/gosym/pclntab.go"
    },
    {
      "type": "modify",
      "old_id": "afc67198c3ffe041cfb33f87a9f18ba049602e75",
      "old_mode": 33188,
      "old_path": "src/debug/gosym/symtab.go",
      "new_id": "d87b312b564b5e27fe2172ddd788a4f2f0602774",
      "new_mode": 33188,
      "new_path": "src/debug/gosym/symtab.go"
    },
    {
      "type": "modify",
      "old_id": "da3c21209d68f11b2ca1fe0a4b2d3a697062fdd4",
      "old_mode": 33188,
      "old_path": "src/debug/gosym/symtab_test.go",
      "new_id": "bb1f267a4dfc25e4cb696d845a0f132609248747",
      "new_mode": 33188,
      "new_path": "src/debug/gosym/symtab_test.go"
    },
    {
      "type": "modify",
      "old_id": "ad34b68c7d5b657f5a8a3c5bc821ee6822f0009f",
      "old_mode": 33188,
      "old_path": "src/runtime/symtab.go",
      "new_id": "4a2d1d90ed489f0ade644234ced9302e120aa1e5",
      "new_mode": 33188,
      "new_path": "src/runtime/symtab.go"
    },
    {
      "type": "modify",
      "old_id": "19e1dbda51c9be69020cf1b8e4f7813113293f9d",
      "old_mode": 33188,
      "old_path": "test/codegen/strings.go",
      "new_id": "08425a418a7378b68e96d7d51c29f2bc2f70f3e2",
      "new_mode": 33188,
      "new_path": "test/codegen/strings.go"
    },
    {
      "type": "modify",
      "old_id": "4293e0100421b4af1e08073f237ae6b965d1bc4f",
      "old_mode": 33188,
      "old_path": "test/fixedbugs/issue29312.go",
      "new_id": "cbf79f704c11b0d27aac175471c01d7c66fad6a2",
      "new_mode": 33188,
      "new_path": "test/fixedbugs/issue29312.go"
    }
  ]
}
