| commit | 0ebd5a8de05823109263bef31b38be8c29d2cd54 | [log] [tgz] |
|---|---|---|
| author | Ian Lance Taylor <iant@golang.org> | Mon Jun 21 14:48:54 2021 -0700 |
| committer | Ian Lance Taylor <iant@golang.org> | Tue Jun 22 16:59:10 2021 +0000 |
| tree | 622e3b567a603030b8b5606113f34c973eea5fd3 | |
| parent | 5bd09e5efccf0d3df89085c9f214f94017f6e969 [diff] |
cmd/go: update ToolTags based on GOARCH value The build.Context ToolTags value is set based on the set of enabled experiments, which in turn depends on GOARCH. Before this CL the set of experiments was being set based on GOARCH in the environment. That is normally fine, but fails with cmd/go when somebody has run "go env -w GOARCH=val"; in that case cmd/go changes its GOARCH value after initialization. The new GOARCH value was affect the set of enabled experiments, which can affect the ToolTags value. With this CL, we update ToolTags in cmd/go based on the GOARCH value it is using. This is a pretty ugly fix. We should do something cleaner for 1.18. Fixes #46815 Change-Id: Ie9416781a168248813c3da8afdc257acdd3fef7e Reviewed-on: https://go-review.googlesource.com/c/go/+/329930 Trust: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.