)]}' { "commit": "0b739fd4df6be871edcc17dd7832142a50a6f80e", "tree": "0f162ae944b8869194b7b6116b9033ee521fcdfb", "parents": [ "e7e2b1c2b91320ef0ddf025d330061d56115dd53" ], "author": { "name": "Matthew Dempsky", "email": "mdempsky@google.com", "time": "Tue Sep 10 20:06:51 2019 -0700" }, "committer": { "name": "Matthew Dempsky", "email": "mdempsky@google.com", "time": "Wed Sep 11 23:33:11 2019 +0000" }, "message": "cmd/compile: move duplicate type-case checking into typecheck\n\nPart of the general trend of moving yyerror calls out of walk and into\ntypecheck.\n\nNotably, this requires splitting test/typeswitch2.go into two files,\nbecause now some of the errors are reported during typecheck and\nothers are still reported during walk; and if there were any errors\nduring typecheck, then cmd/compile exits without invoking walk.\n\nPasses toolstash-check.\n\nChange-Id: I05ee0c00b99af659ee1eef098d342d0d736cf31e\nReviewed-on: https://go-review.googlesource.com/c/go/+/194659\nReviewed-by: Robert Griesemer \u003cgri@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "40c0ea19628e35445263add498211d69f353618d", "old_mode": 33188, "old_path": "src/cmd/compile/internal/gc/swt.go", "new_id": "5089efe08bf4f8407f2305bb5651b8659ae8abdc", "new_mode": 33188, "new_path": "src/cmd/compile/internal/gc/swt.go" }, { "type": "modify", "old_id": "5958b7db8ebd73d5e7b4f747236e6f3fd9a056c0", "old_mode": 33188, "old_path": "test/typeswitch2.go", "new_id": "62c96c8330f6010333dce002269511ba3ee49fff", "new_mode": 33188, "new_path": "test/typeswitch2.go" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "135ae86cff1b88aacfefd4e2c86c4a1497ea701e", "new_mode": 33188, "new_path": "test/typeswitch2b.go" } ] }