)]}'
{
  "commit": "063a91c0abef445154df1ba34ffb500eeccfe8bc",
  "tree": "96be33fdceba41bed0a6a1efb0c09848decf17f4",
  "parents": [
    "715d4e2e014fa54f527ee109f26a31f941196381"
  ],
  "author": {
    "name": "Matthew Dempsky",
    "email": "mdempsky@google.com",
    "time": "Fri Oct 30 12:58:28 2020 -0700"
  },
  "committer": {
    "name": "Matthew Dempsky",
    "email": "mdempsky@google.com",
    "time": "Sun Nov 01 01:06:56 2020 +0000"
  },
  "message": "cmd/compile: fix recognition of unnamed return variables\n\nIn golang.org/cl/266199, I reused the existing code in inlining that\nrecognizes anonymous variables. However, it turns out that code\nmistakenly recognizes anonymous return parameters as named when\ninlining a function from the same package.\n\nThe issue is funcargs (which is only used for functions parsed from\nsource) synthesizes ~r names for anonymous return parameters, but\nfuncargs2 (which is only used for functions imported from export data)\ndoes not.\n\nThis CL fixes the behavior so that anonymous return parameters are\nhandled identically whether a function is inlined within the same\npackage or across packages. It also adds a proper cross-package test\ncase demonstrating #33160 is fixed in both cases.\n\nChange-Id: Iaa39a23f5666979a1f5ca6d09fc8c398e55b784c\nReviewed-on: https://go-review.googlesource.com/c/go/+/266719\nRun-TryBot: Matthew Dempsky \u003cmdempsky@google.com\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Cuong Manh Le \u003ccuong.manhle.vn@gmail.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nTrust: Matthew Dempsky \u003cmdempsky@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8a5c6d86666f6f5e6e85dc0c91def641e0b82a5f",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/gc/inl.go",
      "new_id": "253036fea6417b8167f88a02877f59f1b2ca13e2",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/gc/inl.go"
    },
    {
      "type": "modify",
      "old_id": "fca85c10fbb38539f6ee0812ec228122d35720a5",
      "old_mode": 33188,
      "old_path": "src/cmd/compile/internal/logopt/logopt_test.go",
      "new_id": "51bab49518c079e09c84e813f9a3fb6c88d5af49",
      "new_mode": 33188,
      "new_path": "src/cmd/compile/internal/logopt/logopt_test.go"
    },
    {
      "type": "modify",
      "old_id": "e1271af32d0d6ed86813663518e831fca61324e4",
      "old_mode": 33188,
      "old_path": "test/fixedbugs/issue42284.dir/a.go",
      "new_id": "ffe9310be35b645165ab7b329f168703b9d9867e",
      "new_mode": 33188,
      "new_path": "test/fixedbugs/issue42284.dir/a.go"
    },
    {
      "type": "modify",
      "old_id": "3305166db063ec305c0b42ca1c8dcc718d1d1851",
      "old_mode": 33188,
      "old_path": "test/fixedbugs/issue42284.dir/b.go",
      "new_id": "652aa3212265a32964a027582abab46790f84fc1",
      "new_mode": 33188,
      "new_path": "test/fixedbugs/issue42284.dir/b.go"
    }
  ]
}
