commit 02d8ebda8398342516a24a3e8435d527ed156cab
author Maksim Meshkov <subtle.byte.dev@gmail.com> Sun Feb 05 13:01:19 2023 +0000
committer Gopher Robot <gobot@golang.org> Mon Feb 06 22:13:07 2023 +0000
tree c9c20d7d4c5dd5ba05d4f4885371651c54a341aa
parent 67d8916d551d22f5376e0be71d3922c9d63eaa6a

runtime: fix cpu sample comment

Fixes #58327

Change-Id: I15593e6ee42e04f2de13804ef26e0e66a2307db0
GitHub-Last-Rev: 7e0d04b503d2ba217b76b1ac668a67cd72ec6d7c
GitHub-Pull-Request: golang/go#58338
Reviewed-on: https://go-review.googlesource.com/c/go/+/465335
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/internal/trace/parser.go

diff --git a/src/internal/trace/parser.go b/src/internal/trace/parser.go
index b091a85..8dc2930 100644
--- a/src/internal/trace/parser.go
+++ b/src/internal/trace/parser.go
@@ -1078,7 +1078,7 @@
 	EvUserTaskEnd       = 46 // end of task [timestamp, internal task id, stack]
 	EvUserRegion        = 47 // trace.WithRegion [timestamp, internal task id, mode(0:start, 1:end), stack, name string]
 	EvUserLog           = 48 // trace.Log [timestamp, internal id, key string id, stack, value string]
-	EvCPUSample         = 49 // CPU profiling sample [timestamp, stack, real timestamp, real P id (-1 when absent), goroutine id]
+	EvCPUSample         = 49 // CPU profiling sample [timestamp, real timestamp, real P id (-1 when absent), goroutine id, stack]
 	EvCount             = 50
 )
 

src/runtime/trace.go

diff --git a/src/runtime/trace.go b/src/runtime/trace.go
index d9729cd..b55849f 100644
--- a/src/runtime/trace.go
+++ b/src/runtime/trace.go
@@ -70,7 +70,7 @@
 	traceEvUserTaskEnd       = 46 // end of a task [timestamp, internal task id, stack]
 	traceEvUserRegion        = 47 // trace.WithRegion [timestamp, internal task id, mode(0:start, 1:end), stack, name string]
 	traceEvUserLog           = 48 // trace.Log [timestamp, internal task id, key string id, stack, value string]
-	traceEvCPUSample         = 49 // CPU profiling sample [timestamp, stack, real timestamp, real P id (-1 when absent), goroutine id]
+	traceEvCPUSample         = 49 // CPU profiling sample [timestamp, real timestamp, real P id (-1 when absent), goroutine id, stack]
 	traceEvCount             = 50
 	// Byte is used but only 6 bits are available for event type.
 	// The remaining 2 bits are used to specify the number of arguments.