tree 427bbbf0b8f948c9036e83b44bcc199279de0ac5
parent af0f2af80721261f4d211b2c9563f7b46b2aab06
author Dmitri Shuralyov <dmitshur@golang.org> 1565867556 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> 1565907935 +0000

gosrc: handle not a directory error as not found error

We were correctly handling the error where the file did not exist by
mapping it to NotFoundError, which in turn was served as a normal 404
page to users. We were not handling the error where the file did exist
but was not a directory, which led to user-facing 500 errors.

This change fixes that by adding a check that the opened file is a
directory before attempting to read its contents.

Also, the file that was opened via os.Open was never closed. Fix that.

Fixes golang/gddo#640

Change-Id: I2b0cee6431a81294757b6fd24191fdd27f41ef63
Reviewed-on: https://go-review.googlesource.com/c/gddo/+/190397
Reviewed-by: Tuo Shan <shantuo@google.com>