tree 83d7c41f6bc46b12ab512007abdc5e1269e57b82
parent efd6b22b2522a48712e1fd0b3c1ab34d243f5245
author Russ Cox <rsc@golang.org> 1561574921 -0400
committer Russ Cox <rsc@golang.org> 1561642086 +0000

cmd/modgraphviz: make it a more idiomatic Go command

- Doc comment for command begins with "Name", not "The name command".
- Doc comment usage line is in a code block, not plain text.
- Drop GO111MODULE=on from usage text
  (if people have a module, they have modules on).
- Doc comment text explains usage precisely, beyond usage line.
- Add references to what Graphviz is and also digraph tool.
- Turn off the date/time/file log annotations.
- Print command name as a log prefix.
- Don't print usage message using log.
- Check command-line argument count.
- Change Run(Reader, Writer) to convert(Reader) ([]byte, error)
  to avoid unnecessary error checks on bytes.Buffer.Write
  (which can't fail).
- io.Reader should be named r, not in.
- Use idiomatic bufio.Scanner loop, like in its example.

Change-Id: I74f1a9f58e2dada87eab483183a92eff9ff31cbf
Reviewed-on: https://go-review.googlesource.com/c/exp/+/183982
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>