| commit | f9f960f08ad468ad8961627cf2dfd10baab9dc99 | [log] [tgz] |
|---|---|---|
| author | Jonathan Amsterdam <jba@google.com> | Fri Jan 13 11:51:41 2023 -0500 |
| committer | Jonathan Amsterdam <jba@google.com> | Fri Jan 13 21:37:54 2023 +0000 |
| tree | 383cfc69803061e6d5282a15cd11972d184def13 | |
| parent | 45b9f3160c980181f0ca44383fd3b60b2dcb76f4 [diff] |
slog: change the meaning of slog.bench Originally I believed that it was possible to greatly reduce the time to fetch the pc, so I optimistically used the nopc tag for the "default" slog benchmarks, written to slog.bench. After talking to Austin Clements, I no longer think the runtime will be able to significantly improve the time; instead it is up to this code to speed up pc fetching by reducing the calldepth argument to runtime.Callers, as was done in https://go.dev/cl/458210. So this CL writes to slog.bench for the default, untagged code, and retains the nopc benchmarks in slog-nopc.bench as a lower bound. I did not re-run the benchmarks; I only renamed the files. But git does not seem to notice that. Change-Id: I8e87dd9345db78e0dbd353050b490300e7d65245 Reviewed-on: https://go-review.googlesource.com/c/exp/+/461997 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Jonathan Amsterdam <jba@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>
This subrepository holds experimental and deprecated (in the old directory) packages.
The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.