tree e7373688bab2cbf5ab12a0e9548fc6bc20ac967d
parent 44a13b063f3eef9743622d40c28e664850fd9d37
author Jonathan Amsterdam <jba@google.com> 1677877017 -0500
committer Jonathan Amsterdam <jba@google.com> 1677934523 +0000

slog: change nopc variant from build tag to internal global

During benchmarking, we want to skip the call to runtime.Callers so we
can measure the speedup without it.

Previously we used the build tag `nopc` for this. But build tags are,
in a sense, exported API: anyone can rebuild with a particular tag. In
fact, at least one user believed that `nopc` was a supported feature
of slog.

This CL switches to using a global boolean variable. (The extra time
involved in checking the global is negligible.) To hide the variable
while letting both the slog and benchmarks packages access it,
we put it in an internal package.

Change-Id: I48c133e53c63cd36cc802bbd5f858b74cc19b9e8
Reviewed-on: https://go-review.googlesource.com/c/exp/+/473335
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>