|author||Dmitri Shuralyov <email@example.com>||Mon Apr 08 21:23:43 2019 -0400|
|committer||Dmitri Shuralyov <firstname.lastname@example.org>||Tue Apr 09 01:48:42 2019 +0000|
shiny/driver/gldriver: define GL_SILENCE_DEPRECATION The OpenGL API has been deprecated on macOS as of version 10.14.¹ Building gldriver on macOS 10.14 produces warnings such as: # golang.org/x/exp/shiny/driver/gldriver cgo-gcc-prolog:117:2: warning: 'glBindVertexArray' is deprecated: first deprecated in macOS 10.14 - OpenGL API deprecated. (Define GL_SILENCE_DEPRECATION to silence these warnings) [-Wdeprecated-declarations] /Applications/Xcode.app/.../gl3.h:2360:21: note: 'glBindVertexArray' has been explicitly marked deprecated here cocoa.m:35:2: warning: 'NSOpenGLContext' is deprecated: first deprecated in macOS 10.14 - Please use Metal or MetalKit. [-Wdeprecated-declarations] /Applications/Xcode.app/.../NSOpenGL.h:202:12: note: 'NSOpenGLContext' has been explicitly marked deprecated here ... The package is named gldriver, so it would be too drastic of a change for it to stop using OpenGL. Also, OpenGL is not deprecated on all other platforms that package gldriver supports. Despite being deprecated, OpenGL is not removed from macOS 10.14 at this time. It's not helpful for the warnings to be shown to users who are building and using the package on macOS, so, simply acknowledge the deprecation notice by defining GL_SILENCE_DEPRECATION and silence the warnings. It should also help with x/exp builds passing on https://build.golang.org, because warnings are promoted to errors in trybots (to help catch issues such as this one). References: ¹ https://developer.apple.com/documentation/macos_release_notes/macos_mojave_10_14_release_notes?language=objc#3035786 Updates golang/go#11811 Change-Id: Ie86d03a44c3cdb7aca3ff255bbf7a71926d14025 Reviewed-on: https://go-review.googlesource.com/c/exp/+/171033 Reviewed-by: Brad Fitzpatrick <email@example.com>
This subrepository holds experimental and deprecated (in the
old directory) packages.
The idea for this subrepository originated as the
pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to
go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)