tree c2ce05a65b061b7f15d032b732b4017cc6986b95
parent 7fd597ecf5563971626ffbf559e12e323c9f5602
author Katie Hockman <katie@golang.org> 1554409275 -0400
committer Katie Hockman <katie@golang.org> 1554476823 +0000

notary/internal/tlog: fix bit shifting bug when determining if an index is in a tree

The TileHashReader implementation of ReadHashes was splitting the requested
index into level and n, then bit shifting to decide whether or not the index
existing in the tree of size N. This doesn't work if the index n is 0, and
would then cause infinite looping looking for a parent tile that it knows about.

Note that this bug may exist in other parts of the code as well, but this is
the one that I noticed and was impacting me.

Change-Id: I46e27be0a0fba6d07cbabc6c9ac52cd7b24f2bc0
Reviewed-on: https://go-review.googlesource.com/c/exp/+/170817
Run-TryBot: Katie Hockman <katie@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>