notary/internal/tlog: fix bit shifting bug when determining if an index is in a tree

The TileHashReader implementation of ReadHashes was splitting the requested
index into level and n, then bit shifting to decide whether or not the index
existing in the tree of size N. This doesn't work if the index n is 0, and
would then cause infinite looping looking for a parent tile that it knows about.

Note that this bug may exist in other parts of the code as well, but this is
the one that I noticed and was impacting me.

Change-Id: I46e27be0a0fba6d07cbabc6c9ac52cd7b24f2bc0
Reviewed-on: https://go-review.googlesource.com/c/exp/+/170817
Run-TryBot: Katie Hockman <katie@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
2 files changed
tree: c2ce05a65b061b7f15d032b732b4017cc6986b95
  1. .gitattributes
  2. .gitignore
  3. AUTHORS
  4. CONTRIBUTING.md
  5. CONTRIBUTORS
  6. LICENSE
  7. PATENTS
  8. README.md
  9. apidiff/
  10. cmd/
  11. codereview.cfg
  12. ebnf/
  13. ebnflint/
  14. errors/
  15. fsnotify/
  16. go.mod
  17. go.sum
  18. inotify/
  19. io/
  20. mmap/
  21. notary/
  22. old/
  23. rand/
  24. shiny/
  25. shootout/
  26. utf8string/
  27. winfsnotify/
README.md

exp

This subrepository holds experimental and deprecated (in the old directory) packages.

The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.

Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.

In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)

Caveat emptor.