| commit | e0c80128a2f8b93c798694418db9b3744259d740 | [log] [tgz] |
|---|---|---|
| author | Katie Hockman <katie@golang.org> | Thu Apr 04 16:21:15 2019 -0400 |
| committer | Katie Hockman <katie@golang.org> | Fri Apr 05 15:07:03 2019 +0000 |
| tree | c2ce05a65b061b7f15d032b732b4017cc6986b95 | |
| parent | 7fd597ecf5563971626ffbf559e12e323c9f5602 [diff] |
notary/internal/tlog: fix bit shifting bug when determining if an index is in a tree The TileHashReader implementation of ReadHashes was splitting the requested index into level and n, then bit shifting to decide whether or not the index existing in the tree of size N. This doesn't work if the index n is 0, and would then cause infinite looping looking for a parent tile that it knows about. Note that this bug may exist in other parts of the code as well, but this is the one that I noticed and was impacting me. Change-Id: I46e27be0a0fba6d07cbabc6c9ac52cd7b24f2bc0 Reviewed-on: https://go-review.googlesource.com/c/exp/+/170817 Run-TryBot: Katie Hockman <katie@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
This subrepository holds experimental and deprecated (in the old directory) packages.
The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.