| commit | d63ba01acd4b5892385c4390b334ea2c89f27eb7 | [log] [tgz] |
|---|---|---|
| author | Jonathan Amsterdam <jba@google.com> | Thu Jul 27 06:34:59 2023 -0400 |
| committer | Jonathan Amsterdam <jba@google.com> | Tue Aug 01 11:50:18 2023 +0000 |
| tree | b951d04df0937f6040b995ddfb9905a7a7b51508 | |
| parent | a07a8442513904dd32d078d1ef5418ededb4b620 [diff] |
apidiff: fix comparison of named types in other packages Compare named types from packages other than old and new using their package-qualified names. When determining whether two such types corresponded, we were using the IDs of the types. This was wrong, because the ID for an exported type is just its name, unqualified. The full story is a bit more subtle, because when comparing modules, we want to allow for the module paths to be different. That is left as a TODO. gorelease actually tests for modules with different paths, but its test had a mistaken assumption (see the README.txt in this CL) so we had to change it. Change-Id: Id06eff0b43292088a016d8556e0c7c9c86616289 Reviewed-on: https://go-review.googlesource.com/c/exp/+/513635 Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds experimental and deprecated (in the old directory) packages.
The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.