apidiff: fix comparison of named types in other packages

Compare named types from packages other than old and new using their
package-qualified names.

When determining whether two such types corresponded, we were using
the IDs of the types. This was wrong, because the ID for an exported
type is just its name, unqualified.

The full story is a bit more subtle, because when comparing modules,
we want to allow for the module paths to be different.  That is left
as a TODO.

gorelease actually tests for modules with different paths, but its
test had a mistaken assumption (see the README.txt in this CL) so we
had to change it.

Change-Id: Id06eff0b43292088a016d8556e0c7c9c86616289
Reviewed-on: https://go-review.googlesource.com/c/exp/+/513635
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
5 files changed
tree: b951d04df0937f6040b995ddfb9905a7a7b51508
  1. apidiff/
  2. cmd/
  3. constraints/
  4. devtools/
  5. ebnf/
  6. ebnflint/
  7. errors/
  8. event/
  9. inotify/
  10. io/
  11. jsonrpc2/
  12. maps/
  13. mmap/
  14. rand/
  15. shiny/
  16. shootout/
  17. slices/
  18. slog/
  19. sumdb/
  20. typeparams/
  21. utf8string/
  22. .gitattributes
  23. .gitignore
  24. codereview.cfg
  26. go.mod
  27. go.sum
  30. README.md



This subrepository holds experimental and deprecated (in the old directory) packages.

The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.

Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.

In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)

Caveat emptor.