| commit | d352d2db2ceb4c0411268ee2de764e3f82e27280 | [log] [tgz] |
|---|---|---|
| author | Jean de Klerk <deklerk@google.com> | Fri Jan 29 10:10:24 2021 -0700 |
| committer | Jean de Klerk <deklerk@google.com> | Mon Feb 01 13:15:00 2021 +0000 |
| tree | 801c86390426df2ce3a7ef3d2c540db44d00b354 | |
| parent | 84987778548c8997c44fceeb47b489cd3f37f5ec [diff] |
x/exp/cmd/gorelease: add test for tidy submodule Details: - Adds a test for the missing req submodule case. However, it turns out we don't need any code in the filepath.Walk to handle submodules, since earlier in copyModuleToTempDir we only copy the module's contents (not any submodule contents) with zip.CreateFromDir. This means that prepareLoadDir is never going to consider any submodule content, and we don't have to build logic for that. The test will maintain that guarantee. - Remove some extraneous go.mod dupes from other tests. - Remove a TODO related to filepath.Walk submodule checking which is no longer needed. Fixes golang/go#41456 Change-Id: Ib0bac2fb227d4175c31603880b629374991b8bde Reviewed-on: https://go-review.googlesource.com/c/exp/+/287972 Run-TryBot: Jean de Klerk <deklerk@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Jean de Klerk <deklerk@google.com> Reviewed-by: Jay Conrod <jayconrod@google.com>
This subrepository holds experimental and deprecated (in the old directory) packages.
The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.