| commit | fd42eb6b336fd763bcd0fb5be27323f5587d63d2 | [log] [tgz] |
|---|---|---|
| author | Russ Cox <rsc@golang.org> | Wed Jun 26 14:48:41 2019 -0400 |
| committer | Russ Cox <rsc@golang.org> | Thu Jun 27 13:28:06 2019 +0000 |
| tree | 83d7c41f6bc46b12ab512007abdc5e1269e57b82 | |
| parent | efd6b22b2522a48712e1fd0b3c1ab34d243f5245 [diff] |
cmd/modgraphviz: make it a more idiomatic Go command - Doc comment for command begins with "Name", not "The name command". - Doc comment usage line is in a code block, not plain text. - Drop GO111MODULE=on from usage text (if people have a module, they have modules on). - Doc comment text explains usage precisely, beyond usage line. - Add references to what Graphviz is and also digraph tool. - Turn off the date/time/file log annotations. - Print command name as a log prefix. - Don't print usage message using log. - Check command-line argument count. - Change Run(Reader, Writer) to convert(Reader) ([]byte, error) to avoid unnecessary error checks on bytes.Buffer.Write (which can't fail). - io.Reader should be named r, not in. - Use idiomatic bufio.Scanner loop, like in its example. Change-Id: I74f1a9f58e2dada87eab483183a92eff9ff31cbf Reviewed-on: https://go-review.googlesource.com/c/exp/+/183982 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This subrepository holds experimental and deprecated (in the old directory) packages.
The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.