| commit | 4296e2f59697311b73bf3fdcea2eba224ee676f9 | [log] [tgz] |
|---|---|---|
| author | Jonathan Amsterdam <jba@google.com> | Mon Dec 05 07:03:22 2022 -0500 |
| committer | Jonathan Amsterdam <jba@google.com> | Sun Dec 11 13:37:40 2022 +0000 |
| tree | bd4c30bacfd562d2879dc79df4d7405aff3e2259 | |
| parent | f9028d2d6466dee4ce5ff5160075566c819c2bf2 [diff] |
slog: inform ReplaceAttr of groups Formerly, HandleOptions.ReplaceAttr took only an Attr, so it was ignorant of the groups that contained the Attr. This change provides ReplaceAttr with a slice of currently open groups along with the Attr they contain. We use a sync.Pool to avoid allocating the group slice in the steady state. Also, resolve the Attr's value before passing it to ReplaceAttr. We need to resolve to determine whether the Attr is a Group, so let ReplaceAttr benefit from that work. Change-Id: I9a50e5596f44f93534ce272f0e1681af529fdd94 Reviewed-on: https://go-review.googlesource.com/c/exp/+/455155 Reviewed-by: Alan Donovan <adonovan@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This subrepository holds experimental and deprecated (in the old directory) packages.
The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.