| commit | a9af91da98a38f8564dad0809d4f900c894ea678 | [log] [tgz] |
|---|---|---|
| author | Jonathan Amsterdam <jba@google.com> | Wed Oct 05 19:27:11 2022 -0400 |
| committer | Jonathan Amsterdam <jba@google.com> | Wed Oct 12 21:08:38 2022 +0000 |
| tree | 5913380f50b3c88bc79506923476e060179510dd | |
| parent | 3640c57a48eaf002ca5d5465ef7dac29310631a4 [diff] |
slog: fix SetDefault deadlock
If the program does
SetDefault(Default())
with the original default logger, we end up with deadlock as
the call to log.Output invokes handlerWriter.Write, which
then calls log.Output again while the first invocation holds
the log.Logger mutex.
Fix by not installing a handleWriter if SetDefault's argument has
a defaultHandler.
Change-Id: I0db8a10f313d0e9913a65a75e163d7024ec96589
Reviewed-on: https://go-review.googlesource.com/c/exp/+/439058
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
This subrepository holds experimental and deprecated (in the old directory) packages.
The idea for this subrepository originated as the pkg/exp directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.