commit a5b2ce41f70b6be92fbee9c4d6ef52738e35a8c9
author David Crawshaw <crawshaw@golang.org> Thu Aug 20 09:21:39 2015 -0400
committer David Crawshaw <crawshaw@golang.org> Fri Aug 21 08:34:00 2015 +0000
tree 6dcee52757187cb1495304387f3a0fd923b456fb
parent d9b722afdd8c517bec6ffa720166fc8ab4ce4a28

shiny/driver/gldriver: care for NSWindow lifetime

Two changes. First, create the NSWindow on the main application
thread. I have not found any Cocoa documentation that says this is
necessary, but when in doubt in Cocoa do it on the main thread.

Second, avoid autoreleasing the NSWindow. We are not maintaining any
strong references to it (only the reference from inside the NSView),
so cleaning up the memory is our job. Added a TODO, as when Shiny has
a concept of closing windows, we should free the NSWindow.

Fixes golang/go#12221

Change-Id: I28098228fd1ab89c263634b1903a34571ea2d595
Reviewed-on: https://go-review.googlesource.com/13741
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>